Skip to content

GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raulcd merged 3 commits into from
Jul 24, 2026
+5 −3
Merged

GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_test_emscripten.sh #47403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
283a122
GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_te…
hiroyuki-sato Aug 22, 2025
afa879a
Revert "GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/p…
hiroyuki-sato Aug 26, 2025
bc5e282
GH-47402: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_te…
hiroyuki-sato Aug 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,7 @@ repos:
?^ci/scripts/python_build\.sh$|
?^ci/scripts/python_sdist_build\.sh$|
?^ci/scripts/python_sdist_test\.sh$|
?^ci/scripts/python_test_emscripten\.sh$|
?^ci/scripts/python_wheel_unix_test\.sh$|
?^ci/scripts/python_test_type_annotations\.sh$|
?^ci/scripts/python_test\.sh$|
Expand Down
7 changes: 4 additions & 3 deletions ci/scripts/python_test_emscripten.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,15 @@ set -ex
build_dir=${1}/python
pyodide_dist_dir=${2}

cd ${build_dir}
cd "${build_dir}"

# note: this uses the newest wheel in dist
# shellcheck disable=SC2012
pyodide_wheel=$(ls -t dist/pyarrow*.whl | head -1)

echo "-------------- Running emscripten tests in Node ----------------------"
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=node
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=node

echo "-------------- Running emscripten tests in Chrome --------------------"
python scripts/run_emscripten_tests.py ${pyodide_wheel} --dist-dir=${pyodide_dist_dir} --runtime=chrome
python scripts/run_emscripten_tests.py "${pyodide_wheel}" --dist-dir="${pyodide_dist_dir}" --runtime=chrome

Loading