Skip to content

GH-47481: [C++][Acero] record_batch_reader_source specify Ordering::Implicit to support select * limit k #47482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zanmato1984 merged 3 commits into from
May 24, 2026
Merged

GH-47481: [C++][Acero] record_batch_reader_source specify Ordering::Implicit to support select * limit k #47482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf69c13
RecordBatchReaderSourceNode use Ordering::Implicit
egolearner Sep 3, 2025
a2cbafd
add ut
egolearner May 22, 2026
e575e7c
Merge branch 'main' into batch_reader_source_order
zanmato1984 May 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions cpp/src/arrow/acero/fetch_node_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,28 @@ TEST(FetchNode, Basic) {
CheckFetch({0, 0});
}

TEST(FetchNode, RecordBatchReaderSource) {
constexpr random::SeedType kSeed = 42;
constexpr int kJitterMod = 4;
FetchNodeOptions options{20, 50};
RegisterTestNodes();
std::shared_ptr<Table> input = TestTable();
for (bool use_threads : {false, true}) {
SCOPED_TRACE(use_threads ? "threaded" : "serial");
auto reader = std::make_shared<TableBatchReader>(input);
Declaration plan = Declaration::Sequence(
{{"record_batch_reader_source", RecordBatchReaderSourceNodeOptions{reader}},
{"jitter", JitterNodeOptions(kSeed, kJitterMod)},
{"fetch", options}});
QueryOptions query_options;
query_options.use_threads = use_threads;
ASSERT_OK_AND_ASSIGN(std::shared_ptr<Table> actual,
DeclarationToTable(plan, query_options));
std::shared_ptr<Table> expected = input->Slice(options.offset, options.count);
AssertTablesEqual(*expected, *actual);
}
}

TEST(FetchNode, Invalid) {
CheckFetchInvalid({-1, 10}, "`offset` must be non-negative");
CheckFetchInvalid({10, -1}, "`count` must be non-negative");
Expand Down
2 changes: 1 addition & 1 deletion cpp/src/arrow/acero/source_node.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ struct SchemaSourceNode : public SourceNode {
struct RecordBatchReaderSourceNode : public SourceNode {
RecordBatchReaderSourceNode(ExecPlan* plan, std::shared_ptr<Schema> schema,
arrow::AsyncGenerator<std::optional<ExecBatch>> generator)
: SourceNode(plan, schema, generator) {}
: SourceNode(plan, schema, generator, Ordering::Implicit()) {}

Comment thread
egolearner marked this conversation as resolved.
static Result<ExecNode*> Make(ExecPlan* plan, std::vector<ExecNode*> inputs,
const ExecNodeOptions& options) {
Expand Down
Loading