GH-49133: [C++] Optimize SmallVector move assignment for static storage#49134
Closed
HyukjinKwon wants to merge 1 commit into
Closed
GH-49133: [C++] Optimize SmallVector move assignment for static storage#49134HyukjinKwon wants to merge 1 commit into
HyukjinKwon wants to merge 1 commit into
Conversation
HyukjinKwon
force-pushed
the
remove-non-actionable-todo
branch
from
February 4, 2026 00:57
f230c28 to
2aa870a
Compare
HyukjinKwon
commented
Feb 4, 2026
| storage_type::move_construct_several(other.static_data_, static_data_, size_, N); | ||
| } else { | ||
| // Reset to static storage (in case we had dynamic storage before destroy()) | ||
| data_ = static_data_; |
Member
Author
There was a problem hiding this comment.
This is a piggyback bug fix that is technically not related to this optimization. I found out while benchmarking. I can separate it out if anyone prefers it.
github-actions
Bot
added
awaiting committer review
HyukjinKwon
marked this pull request as draft
February 4, 2026 01:05
HyukjinKwon
force-pushed
the
remove-non-actionable-todo
branch
from
February 4, 2026 02:06
2aa870a to
27aa86c
Compare
HyukjinKwon
marked this pull request as ready for review
February 4, 2026 02:06
HyukjinKwon
force-pushed
the
remove-non-actionable-todo
branch
from
February 4, 2026 02:11
27aa86c to
1e26cd6
Compare
HyukjinKwon
marked this pull request as draft
February 4, 2026 02:16
Member
Author
|
Alright. Seems like the current usages in Arrow itself won't benefit a lot and I don't think this is worthwhile. I will create a new PR (to keep the current implementation as a reference) to remove this TODO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
TBD
What changes are included in this PR?
TBD
Are these changes tested?
TBD
Are there any user-facing changes?
TBD