Skip to content

GH-48862: [C++][Integration] Build arrow_c_data_integration library regardless of ARROW_TEST value#49236

Merged
kou merged 1 commit into
apache:mainfrom
raulcd:GH-48862
Feb 12, 2026
Merged

GH-48862: [C++][Integration] Build arrow_c_data_integration library regardless of ARROW_TEST value#49236
kou merged 1 commit into
apache:mainfrom
raulcd:GH-48862

Conversation

@raulcd

@raulcd raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member

Rationale for this change

Currently if ARROW_TEST=ON the arrow_c_data_integration library is not built. This has been seen on Release verification for 23.0.0 and 23.0.1.

What changes are included in this PR?

Build arrow_c_data_integration library if ARROW_BUILD_INTEGRATION=ON regardless of ARROW_TEST value.

Are these changes tested?

Yes, I've temporarily modified the crossbow job to run both tests and integration and validated the commit fixes the problem and it failed without the fix.

Are there any user-facing changes?

No

@raulcd

raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-*

@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #48862 has been automatically assigned in GitHub to PR creator.

@github-actions

Copy link
Copy Markdown

Revision: df21935

Submitted crossbow builds: ursacomputing/crossbow @ actions-9fefa32cb1

Task Status
verify-rc-source-integration-linux-almalinux-10-amd64 GitHub Actions
verify-rc-source-integration-linux-conda-latest-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-22.04-amd64 GitHub Actions
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions
verify-rc-source-integration-macos-amd64 GitHub Actions
verify-rc-source-integration-macos-arm64 GitHub Actions
verify-rc-source-integration-macos-conda-amd64 GitHub Actions

@raulcd

raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-linux-ubuntu-24.04-amd64

@github-actions

Copy link
Copy Markdown

Revision: 9cc4e27

Submitted crossbow builds: ursacomputing/crossbow @ actions-83d0a25c50

Task Status
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions

@raulcd

raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-linux-ubuntu-24.04-amd64

@github-actions

Copy link
Copy Markdown

Revision: 9ccb197

Submitted crossbow builds: ursacomputing/crossbow @ actions-a7f3795a61

Task Status
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions

@raulcd

raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

@github-actions crossbow submit verify-rc-source-integration-linux-ubuntu-24.04-amd64

@github-actions

Copy link
Copy Markdown

Revision: df21935

Submitted crossbow builds: ursacomputing/crossbow @ actions-5f5ee06bbb

Task Status
verify-rc-source-integration-linux-ubuntu-24.04-amd64 GitHub Actions

@raulcd

raulcd commented Feb 11, 2026

Copy link
Copy Markdown
Member Author

@kou I've validated that if we run both tests and integration the job is now successful. I've also validated it failed without the change.

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@kou
kou merged commit 68d1368 into apache:main Feb 12, 2026
123 of 132 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Feb 12, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Feb 12, 2026
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…rary regardless of ARROW_TEST value (apache#49236)

### Rationale for this change

Currently if `ARROW_TEST=ON` the arrow_c_data_integration library is not built. This has been seen on Release verification for 23.0.0 and 23.0.1.

### What changes are included in this PR?

Build `arrow_c_data_integration` library if `ARROW_BUILD_INTEGRATION=ON` regardless of `ARROW_TEST` value.

### Are these changes tested?

Yes, I've temporarily modified the crossbow job to run both tests and integration and validated the commit fixes the problem and it failed without the fix.

### Are there any user-facing changes?

No

* GitHub Issue: apache#48862

Authored-by: Raúl Cumplido <raulcumplido@gmail.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants