GH-49486: [CI][C++] Fix Meson build missing tensor extension sources#49487
Merged
Conversation
…urces Add tensor_internal.cc and variable_shape_tensor.cc to the arrow_json sources in meson.build, and variable_shape_tensor.h to the installed headers. These files were present in CMakeLists.txt but missing from the Meson build, causing undefined reference linker errors. * GitHub Issue: apache#49486 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
|
Member
|
Oh sorry about this one. I wasn't aware I had to update |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ca68452. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Contributor
Author
|
Not a big deal - Meson is a second tier of support. Seems like AI is pretty good at fixing these inconsistencies anyway, so its not a problem to just have it sweep the config now and again to pick these up |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…urces (apache#49487) ## Summary - Add `extension/tensor_internal.cc` and `extension/variable_shape_tensor.cc` to the `arrow_json` sources in `meson.build` - Add `variable_shape_tensor.h` to installed headers in `extension/meson.build` - These files were present in `CMakeLists.txt` but missing from the Meson build, causing undefined reference linker errors for `variable_shape_tensor()`, `IsPermutationTrivial()`, `IsPermutationValid()`, `ComputeStrides()`, and `SliceTensorBuffer()` ## Test plan - [ ] Verify the Meson CI build passes without linker errors * GitHub Issue: apache#49486 🤖 Generated with [Claude Code](https://claude.com/claude-code) Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…urces (apache#49487) ## Summary - Add `extension/tensor_internal.cc` and `extension/variable_shape_tensor.cc` to the `arrow_json` sources in `meson.build` - Add `variable_shape_tensor.h` to installed headers in `extension/meson.build` - These files were present in `CMakeLists.txt` but missing from the Meson build, causing undefined reference linker errors for `variable_shape_tensor()`, `IsPermutationTrivial()`, `IsPermutationValid()`, `ComputeStrides()`, and `SliceTensorBuffer()` ## Test plan - [ ] Verify the Meson CI build passes without linker errors * GitHub Issue: apache#49486 🤖 Generated with [Claude Code](https://claude.com/claude-code) Authored-by: Will Ayd <william.ayd@icloud.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extension/tensor_internal.ccandextension/variable_shape_tensor.ccto thearrow_jsonsources inmeson.buildvariable_shape_tensor.hto installed headers inextension/meson.buildCMakeLists.txtbut missing from the Meson build, causing undefined reference linker errors forvariable_shape_tensor(),IsPermutationTrivial(),IsPermutationValid(),ComputeStrides(), andSliceTensorBuffer()Test plan
🤖 Generated with Claude Code