GH-49541: [C++] ARROW_FLIGHT_SQL=ON and ARROW_BUILD_EXAMPLES=ON need gflags#49542
Merged
Conversation
…=ON` need gflags
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
Member
Author
|
Right. We don't have a CI for this case. I hit this with |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit ccd0051. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
…=ON` need gflags (apache#49542) ### Rationale for this change `flight-sql-test-server` needs gflags: https://github.com/apache/arrow/blob/6dfef94283d02c6a584640ed7098a73d385814a4/cpp/src/arrow/flight/sql/CMakeLists.txt#L166-L168 ### What changes are included in this PR? Require gflags with `ARROW_FLIGHT_SQL=ON` and `ARROW_BUILD_EXAMPLES=ON`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49541 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
…=ON` need gflags (apache#49542) ### Rationale for this change `flight-sql-test-server` needs gflags: https://github.com/apache/arrow/blob/6dfef94283d02c6a584640ed7098a73d385814a4/cpp/src/arrow/flight/sql/CMakeLists.txt#L166-L168 ### What changes are included in this PR? Require gflags with `ARROW_FLIGHT_SQL=ON` and `ARROW_BUILD_EXAMPLES=ON`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49541 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
flight-sql-test-serverneeds gflags:arrow/cpp/src/arrow/flight/sql/CMakeLists.txt
Lines 166 to 168 in 6dfef94
What changes are included in this PR?
Require gflags with
ARROW_FLIGHT_SQL=ONandARROW_BUILD_EXAMPLES=ON.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.
ARROW_FLIGHT_SQL=ONandARROW_BUILD_EXAMPLES=ONmiss gflags dependency #49541