GH-49499: [C++] Improve arrow vcpkg port integration#49543
Merged
Conversation
We already have CMake configurations only for vcpkg but it's not used when our CMake packages is installed by vcpkg. We can use `ARROW_PACKAGE_KIND=vcpkg` to detect whether our CMake packages are installed by arrow vcpkg port. Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
|
|
github-actions
Bot
added
Component: C++
awaiting committer review
marcin-krystianc
added a commit
to G-Research/ParquetSharp
that referenced
this pull request
Mar 18, 2026
marcin-krystianc
approved these changes
Mar 18, 2026
marcin-krystianc
left a comment
marcin-krystianc
left a comment
Contributor
There was a problem hiding this comment.
FWIW, I'm the original reporter of #49499. I've tested the changes from this PR, and I can confirm it fixes our multi-config build issues.
raulcd
approved these changes
Mar 18, 2026
raulcd
left a comment
raulcd
left a comment
Member
There was a problem hiding this comment.
Thanks @kou and @marcin-krystianc
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9cbd401. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
thisisnic
pushed a commit
to thisisnic/arrow
that referenced
this pull request
Apr 6, 2026
) ### Rationale for this change We already have CMake configurations only for vcpkg but it's not used when our CMake packages is installed by vcpkg. ### What changes are included in this PR? We're using `ARROW_DEPENDENCY_SOURCE=VCPKG` to detect that Apache Arrow is building with dependencies installed by vcpkg but we can't use it in our CMake packages installed by arrow vcpkg port. Because arrow vcpkg port doesn't use `ARROW_DEPENDENCY_SOURCE=VCPKG`. We can use `ARROW_PACKAGE_KIND=vcpkg` to detect whether our CMake packages are installed by arrow vcpkg port. Because arrow vcpkg port uses `ARROW_PACKAGE_KIND=vcpkg`. This also fixes a variable name typo in `FindSnappyAlt`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49499 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
Mottl
pushed a commit
to Mottl/arrow
that referenced
this pull request
May 26, 2026
) ### Rationale for this change We already have CMake configurations only for vcpkg but it's not used when our CMake packages is installed by vcpkg. ### What changes are included in this PR? We're using `ARROW_DEPENDENCY_SOURCE=VCPKG` to detect that Apache Arrow is building with dependencies installed by vcpkg but we can't use it in our CMake packages installed by arrow vcpkg port. Because arrow vcpkg port doesn't use `ARROW_DEPENDENCY_SOURCE=VCPKG`. We can use `ARROW_PACKAGE_KIND=vcpkg` to detect whether our CMake packages are installed by arrow vcpkg port. Because arrow vcpkg port uses `ARROW_PACKAGE_KIND=vcpkg`. This also fixes a variable name typo in `FindSnappyAlt`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#49499 Lead-authored-by: Sutou Kouhei <kou@clear-code.com> Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We already have CMake configurations only for vcpkg but it's not used when our CMake packages is installed by vcpkg.
What changes are included in this PR?
We're using
ARROW_DEPENDENCY_SOURCE=VCPKGto detect that Apache Arrow is building with dependencies installed by vcpkg but we can't use it in our CMake packages installed by arrow vcpkg port. Because arrow vcpkg port doesn't useARROW_DEPENDENCY_SOURCE=VCPKG.We can use
ARROW_PACKAGE_KIND=vcpkgto detect whether our CMake packages are installed by arrow vcpkg port. Because arrow vcpkg port usesARROW_PACKAGE_KIND=vcpkg.This also fixes a variable name typo in
FindSnappyAlt.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.