GH-49569: [CI][Python][C++] Add check targetting Apple clang on deciding whether to use std::bit_width or std::log2p1 by raulcd · Pull Request #49570 · apache/arrow

raulcd · 2026-03-20T10:18:58Z

Rationale for this change

Clang 15.0.7 (/opt/homebrew/bin/clang++) - Homebrew LLVM fails compiling with:

   FAILED: [code=1] CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o
  /opt/homebrew/bin/ccache /opt/homebrew/bin/clang++ -DARROW_HAVE_NEON -DARROW_PYTHON_EXPORTING -Darrow_python_EXPORTS -I/Users/runner/work/arrow/arrow/build/python/pyarrow/src -I/var/folders/gj/d1t24fg93wbdl854js_qwvb00000gn/T/tmpj20nqu3c/build/pyarrow/src -I/Library/Frameworks/Python.framework/Versions/3.11/include/python3.11 -I/tmp/local/include -I/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/numpy/_core/include -fno-aligned-new  -Wall -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a  -Qunused-arguments -fcolor-diagnostics  -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized -Wno-parentheses-equality -Wno-constant-logical-operand -Wno-missing-declarations -Wno-sometimes-uninitialized -Wno-return-type-c-linkage -g -O0  -std=c++20 -arch arm64 -mmacosx-version-min=12 -fPIC -Wno-parentheses-equality -MD -MT CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o -MF CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o.d -o CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o -c /Users/runner/work/arrow/arrow/build/python/pyarrow/src/arrow/python/arrow_to_pandas.cc
  In file included from /Users/runner/work/arrow/arrow/build/python/pyarrow/src/arrow/python/arrow_to_pandas.cc:34:
  In file included from /tmp/local/include/arrow/array.h:41:
  In file included from /tmp/local/include/arrow/array/array_base.h:26:
  In file included from /tmp/local/include/arrow/array/data.h:32:
  /tmp/local/include/arrow/util/bit_util.h:145:15: error: no member named 'log2p1' in namespace 'std'
    return std::log2p1(x - 1);
           ~~~~~^
  1 error generated.

This seems to be the case of clang not having __cpp_lib_bitops defined but std::log2p1 having been removed.

What changes are included in this PR?

Check for __apple_build_version__ instead of __clang__ so non Apple Clang just uses std::bit_width

Are these changes tested?

Via CI

Are there any user-facing changes?

No

GitHub Issue: [CI][Python][C++] macos 14 fails with missing std::log2p1 #49569

…ciding whether to use std::bit_width or std::log2p1

raulcd · 2026-03-20T10:20:48Z

@github-actions crossbow submit test-r-macos-as-cran test-ubuntu-22.04-cpp-emscripten

github-actions · 2026-03-20T10:21:10Z

⚠️ GitHub issue #49569 has been automatically assigned in GitHub to PR creator.

github-actions · 2026-03-20T10:23:54Z

Revision: 066bf57

Submitted crossbow builds: ursacomputing/crossbow @ actions-576a7cbdce

Task	Status
test-r-macos-as-cran
test-ubuntu-22.04-cpp-emscripten

raulcd · 2026-03-20T10:44:36Z

@github-actions crossbow submit test-r-macos-as-cran test-ubuntu-22.04-cpp-emscripten

github-actions · 2026-03-20T10:47:31Z

Revision: a982f19

Submitted crossbow builds: ursacomputing/crossbow @ actions-d0624cbd1c

Task	Status
test-r-macos-as-cran
test-ubuntu-22.04-cpp-emscripten

raulcd · 2026-03-20T11:17:04Z

Failing job is now successful:
https://github.com/apache/arrow/actions/runs/23339381294/job/67889069638?pr=49570

raulcd · 2026-03-20T12:47:52Z

@github-actions crossbow submit test-r-macos-as-cran test-ubuntu-22.04-cpp-emscripten

github-actions · 2026-03-20T12:50:06Z

Revision: 4736f08

Submitted crossbow builds: ursacomputing/crossbow @ actions-025f27de49

Task	Status
test-r-macos-as-cran
test-ubuntu-22.04-cpp-emscripten

raulcd · 2026-03-20T13:43:37Z

@kou @jonkeane what do you think about this. This was failing on the ARM64 macOS 14 Python 3 before but is now successful. The problem was with non-Apple clang on macOS. It failed using the one from homebrew.

kou

+1

I didn't know __apple_build_version__!

jonkeane

Yes, this is great, thanks! The other failure is a warning that Nic is working on already in #49530

conbench-apache-arrow · 2026-03-23T15:34:40Z

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit ba273ca.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

… deciding whether to use std::bit_width or std::log2p1 (apache#49570) ### Rationale for this change Clang 15.0.7 (/opt/homebrew/bin/clang++) - Homebrew LLVM fails compiling with: ``` FAILED: [code=1] CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o /opt/homebrew/bin/ccache /opt/homebrew/bin/clang++ -DARROW_HAVE_NEON -DARROW_PYTHON_EXPORTING -Darrow_python_EXPORTS -I/Users/runner/work/arrow/arrow/build/python/pyarrow/src -I/var/folders/gj/d1t24fg93wbdl854js_qwvb00000gn/T/tmpj20nqu3c/build/pyarrow/src -I/Library/Frameworks/Python.framework/Versions/3.11/include/python3.11 -I/tmp/local/include -I/Library/Frameworks/Python.framework/Versions/3.11/lib/python3.11/site-packages/numpy/_core/include -fno-aligned-new -Wall -Wno-unknown-warning-option -Wno-pass-failed -march=armv8-a -Qunused-arguments -fcolor-diagnostics -fno-omit-frame-pointer -Wno-unused-variable -Wno-maybe-uninitialized -Wno-parentheses-equality -Wno-constant-logical-operand -Wno-missing-declarations -Wno-sometimes-uninitialized -Wno-return-type-c-linkage -g -O0 -std=c++20 -arch arm64 -mmacosx-version-min=12 -fPIC -Wno-parentheses-equality -MD -MT CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o -MF CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o.d -o CMakeFiles/arrow_python.dir/pyarrow/src/arrow/python/arrow_to_pandas.cc.o -c /Users/runner/work/arrow/arrow/build/python/pyarrow/src/arrow/python/arrow_to_pandas.cc In file included from /Users/runner/work/arrow/arrow/build/python/pyarrow/src/arrow/python/arrow_to_pandas.cc:34: In file included from /tmp/local/include/arrow/array.h:41: In file included from /tmp/local/include/arrow/array/array_base.h:26: In file included from /tmp/local/include/arrow/array/data.h:32: /tmp/local/include/arrow/util/bit_util.h:145:15: error: no member named 'log2p1' in namespace 'std' return std::log2p1(x - 1); ~~~~~^ 1 error generated. ``` This seems to be the case of clang not having `__cpp_lib_bitops` defined but `std::log2p1` having been removed. ### What changes are included in this PR? Check for `__apple_build_version__` instead of `__clang__` so non Apple Clang just uses `std::bit_width` ### Are these changes tested? Via CI ### Are there any user-facing changes? No * GitHub Issue: apache#49569 Authored-by: Raúl Cumplido <raulcumplido@gmail.com> Signed-off-by: Raúl Cumplido <raulcumplido@gmail.com>

apacheGH-49569: [CI][Python][C++] Add check for _LIBCPP_VERSION on de…

066bf57

…ciding whether to use std::bit_width or std::log2p1

github-actions Bot added awaiting committer review Awaiting committer review Component: C++ labels Mar 20, 2026

Try using __apple_build_version__ instead of __clang__

a982f19

raulcd changed the title ~~GH-49569: [CI][Python][C++] Add check for _LIBCPP_VERSION on deciding whether to use std::bit_width or std::log2p1~~ GH-49569: [CI][Python][C++] Add check targetting apple clang on deciding whether to use std::bit_width or std::log2p1 Mar 20, 2026

raulcd changed the title ~~GH-49569: [CI][Python][C++] Add check targetting apple clang on deciding whether to use std::bit_width or std::log2p1~~ GH-49569: [CI][Python][C++] Add check targetting Apple clang on deciding whether to use std::bit_width or std::log2p1 Mar 20, 2026

raulcd marked this pull request as ready for review March 20, 2026 12:43

Add the change into other places we perform the check

4736f08

raulcd requested a review from wgtmac as a code owner March 20, 2026 12:47

github-actions Bot added the Component: Parquet label Mar 20, 2026

kou approved these changes Mar 20, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting committer review Awaiting committer review labels Mar 20, 2026

jonkeane approved these changes Mar 21, 2026

View reviewed changes

raulcd merged commit ba273ca into apache:main Mar 23, 2026
55 of 56 checks passed

raulcd removed the awaiting merge Awaiting merge label Mar 23, 2026

raulcd mentioned this pull request Mar 23, 2026

[CI][Python][C++] macos 14 fails with missing std::log2p1 #49569

Closed

ryandesign mentioned this pull request Apr 22, 2026

[C++] error: no member named 'log2p1' in namespace 'std' #49841

Open

Uh oh!

Conversation

raulcd commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

raulcd commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

raulcd commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

raulcd commented Mar 20, 2026

Uh oh!

raulcd commented Mar 20, 2026

Uh oh!

github-actions Bot commented Mar 20, 2026

Uh oh!

raulcd commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

jonkeane left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

conbench-apache-arrow Bot commented Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raulcd commented Mar 20, 2026 •

edited

Loading

raulcd commented Mar 20, 2026 •

edited

Loading