Skip to content

GH-49576: [Ruby] Add support for custom metadata in Footer#49577

Merged
kou merged 1 commit into
apache:mainfrom
kou:ruby-custom-metadata-footer
Mar 22, 2026
Merged

GH-49576: [Ruby] Add support for custom metadata in Footer#49577
kou merged 1 commit into
apache:mainfrom
kou:ruby-custom-metadata-footer

Conversation

@kou

@kou kou commented Mar 21, 2026

Copy link
Copy Markdown
Member

Rationale for this change

In file format, Footer can have custom metadata.

What changes are included in this PR?

  • Add garrow_record_batch_file_reader_get_metadata()
  • Add garrow_record_batch_file_writer_new_full()
  • Add ArrowFormat::FileReader#metadata
  • Add metadata to ArrowFormat::FileWriter#finish
  • Add metadata: to Arrow::Table#save

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

In file format, Footer can have custom metadata.

* Add `garrow_record_batch_file_reader_get_metadata()`
* Add `garrow_record_batch_file_writer_new_full()`
* Add `ArrowFormat::FileReader#metadata`
* Add `metadata` to `ArrowFormat::FileWriter#finish`
* Add `metadata:` to `Arrow::Table#save`
@github-actions

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@kou kou changed the title [Ruby] Add support for custom metadata in Footer GH-49576: [Ruby] Add support for custom metadata in Footer Mar 22, 2026
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49576 has been automatically assigned in GitHub to PR creator.

@kou

kou commented Mar 22, 2026

Copy link
Copy Markdown
Member Author

+1

@kou
kou merged commit c24bc29 into apache:main Mar 22, 2026
13 of 14 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Mar 22, 2026
@kou
kou deleted the ruby-custom-metadata-footer branch March 22, 2026 21:32
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 2 benchmarking runs that have been run so far on merge-commit c24bc29.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 20 possible false positives for unstable benchmarks that are known to sometimes produce them.

thisisnic pushed a commit to thisisnic/arrow that referenced this pull request Apr 6, 2026
…che#49577)

### Rationale for this change

In file format, Footer can have custom metadata.

### What changes are included in this PR?

* Add `garrow_record_batch_file_reader_get_metadata()`
* Add `garrow_record_batch_file_writer_new_full()`
* Add `ArrowFormat::FileReader#metadata`
* Add `metadata` to `ArrowFormat::FileWriter#finish`
* Add `metadata:` to `Arrow::Table#save`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* GitHub Issue: apache#49576

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…che#49577)

### Rationale for this change

In file format, Footer can have custom metadata.

### What changes are included in this PR?

* Add `garrow_record_batch_file_reader_get_metadata()`
* Add `garrow_record_batch_file_writer_new_full()`
* Add `ArrowFormat::FileReader#metadata`
* Add `metadata` to `ArrowFormat::FileWriter#finish`
* Add `metadata:` to `Arrow::Table#save`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.

* GitHub Issue: apache#49576

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant