Skip to content

GH-49601: [C++] Update bundled AWS SDK C++ for C23 #49604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kou merged 1 commit into from
Mar 28, 2026
Merged

GH-49601: [C++] Update bundled AWS SDK C++ for C23 #49604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions cpp/cmake_modules/ThirdpartyToolchain.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3882,6 +3882,10 @@ function(build_awssdk)
string(APPEND CMAKE_C_FLAGS " -D_WIN32_WINNT=0x0601")
string(APPEND CMAKE_CXX_FLAGS " -D_WIN32_WINNT=0x0601")
endif()
if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
string(APPEND CMAKE_C_FLAGS " -Wno-implicit-fallthrough")
string(APPEND CMAKE_CXX_FLAGS " -Wno-implicit-fallthrough")
endif()
Comment on lines +3885 to +3888

Copilot AI Mar 27, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The -Wno-implicit-fallthrough flag is being added based on CMAKE_CXX_COMPILER_ID, but it’s appended to both CMAKE_C_FLAGS and CMAKE_CXX_FLAGS. In mixed-toolchain setups (different C and C++ compilers), this can fail to apply when needed or apply based on the wrong compiler. Consider checking CMAKE_C_COMPILER_ID for the C flags and CMAKE_CXX_COMPILER_ID for the C++ flags (or guarding each independently), ideally using check_c_compiler_flag/check_cxx_compiler_flag so unsupported flags don’t break builds.

Copilot uses AI. Check for mistakes.

# For aws-lc
set(DISABLE_GO ON)
Expand Down
56 changes: 28 additions & 28 deletions cpp/thirdparty/versions.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,34 +25,34 @@

ARROW_ABSL_BUILD_VERSION=20211102.0
ARROW_ABSL_BUILD_SHA256_CHECKSUM=dcf71b9cba8dc0ca9940c4b316a0c796be8fab42b070bb6b7cab62b48f0e66c4
ARROW_AWS_C_AUTH_BUILD_VERSION=v0.9.0
ARROW_AWS_C_AUTH_BUILD_SHA256_CHECKSUM=aa6e98864fefb95c249c100da4ae7aed36ba13a8a91415791ec6fad20bec0427
ARROW_AWS_C_CAL_BUILD_VERSION=v0.9.2
ARROW_AWS_C_CAL_BUILD_SHA256_CHECKSUM=f9f3bc6a069e2efe25fcdf73e4d2b16b5608c327d2eb57c8f7a8524e9e1fcad0
ARROW_AWS_C_COMMON_BUILD_VERSION=v0.12.4
ARROW_AWS_C_COMMON_BUILD_SHA256_CHECKSUM=0b7705a4d115663c3f485d353a75ed86e37583157585e5825d851af634b57fe3
ARROW_AWS_C_COMPRESSION_BUILD_VERSION=v0.3.1
ARROW_AWS_C_COMPRESSION_BUILD_SHA256_CHECKSUM=d89fca17a37de762dc34f332d2da402343078da8dbd2224c46a11a88adddf754
ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION=v0.5.4
ARROW_AWS_C_EVENT_STREAM_BUILD_SHA256_CHECKSUM=cef8b78e362836d15514110fb43a0a0c7a86b0a210d5fe25fd248a82027a7272
ARROW_AWS_C_HTTP_BUILD_VERSION=v0.10.2
ARROW_AWS_C_HTTP_BUILD_SHA256_CHECKSUM=048d9d683459ade363fd7cc448c2b6329c78f67a2a0c0cb61c16de4634a2fc6b
ARROW_AWS_C_IO_BUILD_VERSION=v0.19.1
ARROW_AWS_C_IO_BUILD_SHA256_CHECKSUM=f2fea0c066924f7fe3c2b1c7b2fa9be640f5b16a6514854226330e63a1faacd0
ARROW_AWS_C_MQTT_BUILD_VERSION=v0.13.1
ARROW_AWS_C_MQTT_BUILD_SHA256_CHECKSUM=c54d02c1e46f55bae8d5e6f9c4b0d78d84c1c9d9ac16ba8d78c3361edcd8b5bb
ARROW_AWS_C_S3_BUILD_VERSION=v0.8.1
ARROW_AWS_C_S3_BUILD_SHA256_CHECKSUM=c8b09780691d2b94e50d101c68f01fa2d1c3debb0ff3aed313d93f0d3c9af663
ARROW_AWS_C_AUTH_BUILD_VERSION=v0.10.1
ARROW_AWS_C_AUTH_BUILD_SHA256_CHECKSUM=85d737f0f735256f1931e85e4cadbe228d88698f7b59a9b390b49ef5d0778a43
ARROW_AWS_C_CAL_BUILD_VERSION=v0.9.13
ARROW_AWS_C_CAL_BUILD_SHA256_CHECKSUM=80b7c6087b0af461b4483e4c9483aea2e0dac5d9fb2289b057159ea6032409e1
ARROW_AWS_C_COMMON_BUILD_VERSION=v0.12.6
ARROW_AWS_C_COMMON_BUILD_SHA256_CHECKSUM=138822ecdcaff1d702f37d4751f245847d088592724921cc6bf61c232b198d6b
ARROW_AWS_C_COMPRESSION_BUILD_VERSION=v0.3.2
ARROW_AWS_C_COMPRESSION_BUILD_SHA256_CHECKSUM=f93f5a5d8b3fee3a6d97b14ba279efacd4d4016ef9cc7dc4be7d43519ecfbe93
ARROW_AWS_C_EVENT_STREAM_BUILD_VERSION=v0.7.0
ARROW_AWS_C_EVENT_STREAM_BUILD_SHA256_CHECKSUM=88835b4c78462547917f622fd9dda45c991b7e356d9c07e2f0537d4d97fbd4fb
ARROW_AWS_C_HTTP_BUILD_VERSION=v0.10.13
ARROW_AWS_C_HTTP_BUILD_SHA256_CHECKSUM=d8352e7a1fb1996694a4dc31219ce03452882abf8d0858c104727f975e11b9c7
ARROW_AWS_C_IO_BUILD_VERSION=v0.26.3
ARROW_AWS_C_IO_BUILD_SHA256_CHECKSUM=521fd0848fca661130bbb7278a414d7a38bdcb9bc8ffa89f6660d84e5838a303
ARROW_AWS_C_MQTT_BUILD_VERSION=v0.15.2
ARROW_AWS_C_MQTT_BUILD_SHA256_CHECKSUM=66f3f5edff4ad1f765a86d3342b6017d0f29f950c1c24f8c1edacdc895202edc
ARROW_AWS_C_S3_BUILD_VERSION=v0.12.0
ARROW_AWS_C_S3_BUILD_SHA256_CHECKSUM=1a8a8ceda0585d52028a1f3daa5861f924e7d8d2f6a17bec05813dc0b74d6eed
ARROW_AWS_C_SDKUTILS_BUILD_VERSION=v0.2.4
ARROW_AWS_C_SDKUTILS_BUILD_SHA256_CHECKSUM=493cbed4fa57e0d4622fcff044e11305eb4fc12445f32c8861025597939175fc
ARROW_AWS_CHECKSUMS_BUILD_VERSION=v0.2.7
ARROW_AWS_CHECKSUMS_BUILD_SHA256_CHECKSUM=178e8398d98111f29150f7813a70c20ad97ab30be0de02525440355fe84ccb1d
ARROW_AWS_CRT_CPP_BUILD_VERSION=v0.32.8
ARROW_AWS_CRT_CPP_BUILD_SHA256_CHECKSUM=db44260452a0296341fb8e7b987e4c328f08f7829b9f1c740fed9c963e081e93
ARROW_AWS_LC_BUILD_VERSION=v1.52.1
ARROW_AWS_LC_BUILD_SHA256_CHECKSUM=fe552e3c3522f73afc3c30011745c431c633f7b4e25dcd7b38325f194a7b3b75
ARROW_AWSSDK_BUILD_VERSION=1.11.587
ARROW_AWSSDK_BUILD_SHA256_CHECKSUM=b9944ba9905a68d6e53abb4f36ab2b3bd18ac88d8571647bb9f2b8026b76f8cd
ARROW_AWS_CHECKSUMS_BUILD_VERSION=v0.2.10
ARROW_AWS_CHECKSUMS_BUILD_SHA256_CHECKSUM=cb6509f75e42ee25c372a6d379e8582ce5179e5335183842e808f7d8abb0c314
ARROW_AWS_CRT_CPP_BUILD_VERSION=v0.38.0
ARROW_AWS_CRT_CPP_BUILD_SHA256_CHECKSUM=f57b82f0a9e6890e4d47aa1c48b9324b5beb5b58000715c4c6ef9f147be13891
ARROW_AWS_LC_BUILD_VERSION=v1.71.0
ARROW_AWS_LC_BUILD_SHA256_CHECKSUM=31b1eed775294825f084c0d4e09df53e1cf036fb98a202a8c2c342543828a985
ARROW_AWSSDK_BUILD_VERSION=1.11.778
ARROW_AWSSDK_BUILD_SHA256_CHECKSUM=06371849792f1a8633c3e0592a17b4700f39c748ad374f4e9a6592739ecc4d9c
# Despite the confusing version name this is still the whole Azure SDK for C++ including core, keyvault, storage-common, etc.
ARROW_AZURE_SDK_BUILD_VERSION=azure-identity_1.9.0
ARROW_AZURE_SDK_BUILD_SHA256_CHECKSUM=97065bfc971ac8df450853ce805f820f52b59457bd7556510186a1569502e4a1
Expand Down Expand Up @@ -108,8 +108,8 @@ ARROW_SNAPPY_BUILD_VERSION=1.2.2
ARROW_SNAPPY_BUILD_SHA256_CHECKSUM=90f74bc1fbf78a6c56b3c4a082a05103b3a56bb17bca1a27e052ea11723292dc
ARROW_SUBSTRAIT_BUILD_VERSION=v0.44.0
ARROW_SUBSTRAIT_BUILD_SHA256_CHECKSUM=f989a862f694e7dbb695925ddb7c4ce06aa6c51aca945105c075139aed7e55a2
ARROW_S2N_TLS_BUILD_VERSION=v1.5.23
ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM=81961ea5ae9313c987edfa579306ad4500bedfbf10caf84d8a5dcfc42aaf591f
ARROW_S2N_TLS_BUILD_VERSION=v1.7.0
ARROW_S2N_TLS_BUILD_SHA256_CHECKSUM=a6e8228e238239bb3c17b1eda3ed702bcbb2eaebc792eac4d754cc5619b0ea06
ARROW_THRIFT_BUILD_VERSION=0.22.0
ARROW_THRIFT_BUILD_SHA256_CHECKSUM=794a0e455787960d9f27ab92c38e34da27e8deeda7a5db0e59dc64a00df8a1e5
ARROW_UTF8PROC_BUILD_VERSION=v2.10.0
Expand Down
Loading