Skip to content

GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790

Merged
kou merged 1 commit into
apache:mainfrom
kou:cpp-arrow-doc-dir
Apr 20, 2026
Merged

GH-49789: [C++] Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}#49790
kou merged 1 commit into
apache:mainfrom
kou:cpp-arrow-doc-dir

Conversation

@kou

@kou kou commented Apr 18, 2026

Copy link
Copy Markdown
Member

Rationale for this change

CMAKE_INSTALL_DOCDIR is the standard variable for install document directory. Packages use this variable to change install document directory.

What changes are included in this PR?

Use CMAKE_INSTALL_DOCDIR instead of static share/doc/${PROJECT_NAME}

Are these changes tested?

Yes.

Are there any user-facing changes?

Yes.

Copilot AI review requested due to automatic review settings April 18, 2026 12:44
@github-actions

Copy link
Copy Markdown

⚠️ GitHub issue #49789 has been automatically assigned in GitHub to PR creator.

@kou kou added CI: Extra: Package: Linux Run extra Linux Packages CI and removed Component: C++ labels Apr 18, 2026
@github-actions github-actions Bot added the awaiting committer review Awaiting committer review label Apr 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Arrow C++’s install configuration to use CMake’s standard documentation install directory variable (CMAKE_INSTALL_DOCDIR) instead of a hard-coded share/doc/${PROJECT_NAME}, improving compatibility with downstream packagers and custom install layouts.

Changes:

  • Switch ARROW_DOC_DIR from a static path to ${CMAKE_INSTALL_DOCDIR}.
  • Keep existing documentation-related install rules (LICENSE/NOTICE/README) but route them through the standardized docdir variable.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@kou

kou commented Apr 20, 2026

Copy link
Copy Markdown
Member Author

+1

@kou
kou merged commit 09cc2cf into apache:main Apr 20, 2026
94 of 96 checks passed
@kou kou removed the awaiting committer review Awaiting committer review label Apr 20, 2026
@kou
kou deleted the cpp-arrow-doc-dir branch April 20, 2026 11:17
@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 09cc2cf.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Mottl pushed a commit to Mottl/arrow that referenced this pull request May 26, 2026
…hare/doc/${PROJECT_NAME}` (apache#49790)

### Rationale for this change

`CMAKE_INSTALL_DOCDIR` is the standard variable for install document directory. Packages use this variable to change install document directory.

### What changes are included in this PR?

Use `CMAKE_INSTALL_DOCDIR` instead of static `share/doc/${PROJECT_NAME}`

### Are these changes tested?

Yes.

### Are there any user-facing changes?

Yes.
* GitHub Issue: apache#49789

Authored-by: Sutou Kouhei <kou@clear-code.com>
Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Extra: Package: Linux Run extra Linux Packages CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants