GH-49744: [Integration][Format] Remove unneeded skips for Rust and nanoarrow integration tests#49910
Merged
Merged
Conversation
|
|
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
paleolimbot
added a commit
to apache/arrow-nanoarrow
that referenced
this pull request
May 11, 2026
…test utilities (#880) In pursuit of removing skips in the integration test for apache/arrow#49910 . While the IPC reader has supported Decimal 32 and 64 since the beginning, the JSON parser hasn't. The file reader for the integration tests also was never updated to support dictionary batches. To fully support the integration test we also need a writer for dictionaries which is a bit more involved and I'll do it in another PR. --------- Co-authored-by: Copilot <copilot@github.com>
alamb
pushed a commit
to apache/arrow-rs
that referenced
this pull request
May 14, 2026
…SON parser (#9888) # Which issue does this PR close? Supporting unskipping more types in the Rust IPC/C Data tests for apache/arrow#49910 / apache/arrow#49744 . # Rationale for this change View types and decimal 32/64 are supported in Rust but aren't supported in the integration test JSON implementation (so they fail when the integration test tries to check them). # What changes are included in this PR? Integration test JSON now supports how these values are represented. # Are these changes tested? Yes. I've added to the embedded integration.json for the new types and I've run the apache/arrow PR against this branch with these types no longer being skipped. # Are there any user-facing changes? No --------- Co-authored-by: Copilot <copilot@github.com>
Contributor
|
🥳 |
alamb
reviewed
May 15, 2026
| .skip_tester('JS') | ||
| .skip_tester('nanoarrow') | ||
| .skip_tester('Ruby') | ||
| .skip_tester('Rust') |
github-actions
Bot
added
awaiting changes
paleolimbot
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
github-actions
Bot
added
awaiting merge
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 72bb3e3. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 22 possible false positives for unstable benchmarks that are known to sometimes produce them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The current skip list in the Archery datagen (where the skip list is kept) is out of date.
What changes are included in this PR?
Skips were removed.
Are these changes tested?
Yes, the integration test CI run should ensure these skips can in fact be removed.
Are there any user-facing changes?
No