GH-50052: [CI][C++] Bump vcpkg to newest version#50053
Conversation
|
|
|
@github-actions crossbow submit wheelcp314 |
|
Revision: a0e4312 Submitted crossbow builds: ursacomputing/crossbow @ actions-de3763ceb9
|
There was a problem hiding this comment.
Pull request overview
This PR updates Arrow’s CI/container toolchain to use a newer vcpkg commit, along with supporting tweaks needed for dependency builds (notably in the manylinux wheel image).
Changes:
- Bump the default vcpkg commit used by CI/docker builds and refresh the vcpkg ports patch accordingly.
- Add a CI helper script to build/install a newer bison, and install it in the manylinux Python wheel image to satisfy thrift build requirements.
- Update Windows wheel image revision tags to force rebuilds with the new vcpkg/tooling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
ci/vcpkg/ports.patch |
Updates vcpkg port overlays/patches for the bumped vcpkg baseline. |
ci/scripts/install_bison.sh |
Adds a script to build and install a pinned bison version from source. |
ci/docker/python-wheel-manylinux.dockerfile |
Installs newer bison in the manylinux wheel build image before running vcpkg. |
.env |
Updates the pinned vcpkg commit and Windows wheel image revision tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
github-actions
Bot
added
awaiting changes
github-actions
Bot
added
awaiting change review
raulcd
added
awaiting changes
|
@github-actions crossbow submit wheelcp313 |
|
Revision: 01d11b7 Submitted crossbow builds: ursacomputing/crossbow @ actions-3800d85dfe
|
|
@kou @AntoinePrv this is ready. CI is green for wheels and JNI manylinux jobs. |
| set -e | ||
|
|
||
| if [ "$#" -ne 2 ]; then | ||
| echo "Usage: $0 <version> <prefix>" | ||
| exit 1 | ||
| fi | ||
|
|
||
| version=$1 | ||
| prefix=$2 | ||
|
|
||
| mkdir -p /tmp/bison | ||
| url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz" | ||
|
|
||
| wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 | ||
|
|
| mkdir -p /tmp/bison | ||
| url="https://ftp.gnu.org/gnu/bison/bison-${version}.tar.gz" | ||
|
|
||
| wget -q "${url}" -O - | tar -xzf - --directory /tmp/bison --strip-components=1 | ||
|
|
||
| pushd /tmp/bison | ||
| ./configure --prefix="${prefix}" | ||
| make -j$(nproc) | ||
| make install | ||
| popd | ||
|
|
||
| rm -rf /tmp/bison |
kou
left a comment
kou
left a comment
There was a problem hiding this comment.
+1
BTW, I thought that we may be able to install Bison by vcpkg but it's not available yet: microsoft/vcpkg#33084
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 9dcedab. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 6 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
We require newer vcpkg for other PRs like upgrading xsimd, see:
What changes are included in this PR?
Are these changes tested?
Yes via CI
Are there any user-facing changes?
No