Skip to content

GH-50063: [C++] Validate buffer size for row-major tensors #50064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rok merged 1 commit into from
May 29, 2026
Merged

GH-50063: [C++] Validate buffer size for row-major tensors #50064

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/src/arrow/tensor.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,6 +216,7 @@ Status ValidateTensorParameters(const std::shared_ptr<DataType>& type,
std::vector<int64_t> tmp_strides;
RETURN_NOT_OK(ComputeRowMajorStrides(checked_cast<const FixedWidthType&>(*type),
shape, &tmp_strides));
RETURN_NOT_OK(CheckTensorStridesValidity(data, shape, tmp_strides, type));
}
if (dim_names.size() > shape.size()) {
return Status::Invalid("too many dim_names are supplied");
Expand Down
3 changes: 3 additions & 0 deletions cpp/src/arrow/tensor_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,6 +268,9 @@ TEST(TestTensor, MakeFailureCases) {
ASSERT_RAISES(Invalid, Tensor::Make(float64(), data, shape,
{sizeof(double) * 12, sizeof(double)}));

// row-major (implicit strides) shape larger than the backing buffer
ASSERT_RAISES(Invalid, Tensor::Make(float64(), data, {3, 100}));

// too many dim_names are supplied
ASSERT_RAISES(Invalid, Tensor::Make(float64(), data, shape, {}, {"foo", "bar", "baz"}));
}
Expand Down
Loading