Skip to content

MINOR: [C++] Replace NULLPTR with nullptr inside registry.cc#50118

Merged
kou merged 1 commit into
apache:mainfrom
andishgar:correct_nullptr
Jun 10, 2026
Merged

MINOR: [C++] Replace NULLPTR with nullptr inside registry.cc#50118
kou merged 1 commit into
apache:mainfrom
andishgar:correct_nullptr

Conversation

@andishgar

Copy link
Copy Markdown
Contributor

Rationale for this change

As mentioned here, NULLPTR must be used in headers. However, NULLPTR is used inside arrow/compute/registry.cc instead of nullptr.

What changes are included in this PR?

Replace NULLPTR with nullptr.

Are these changes tested?

Yes, I ran the unit tests.

Are there any user-facing changes?

No.

@github-actions

github-actions Bot commented Jun 7, 2026

Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@andishgar andishgar changed the title MINOR : Replace NULLPTR with nullptr MINOR : [C++] Replace NULLPTR with nullptr Jun 7, 2026
@andishgar andishgar changed the title MINOR : [C++] Replace NULLPTR with nullptr MINOR : [C++] Replace NULLPTR with nullptr inside registry.cc Jun 7, 2026
@pitrou pitrou changed the title MINOR : [C++] Replace NULLPTR with nullptr inside registry.cc MINOR: [C++] Replace NULLPTR with nullptr inside registry.cc Jun 10, 2026
@pitrou

pitrou commented Jun 10, 2026

Copy link
Copy Markdown
Member

@kou Do you think this is ok as a minor PR?

@kou kou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

This should not be a MINOR PR for us: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes

Could you create an issue next time?

@kou
kou merged commit ee0d861 into apache:main Jun 10, 2026
58 of 59 checks passed
@kou kou removed the awaiting review Awaiting review label Jun 10, 2026
@github-actions github-actions Bot added the awaiting merge Awaiting merge label Jun 10, 2026
@andishgar
andishgar deleted the correct_nullptr branch June 11, 2026 06:45
@andishgar

Copy link
Copy Markdown
Contributor Author

Thanks, @kou. I will consider your advice.

@conbench-apache-arrow

Copy link
Copy Markdown

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ee0d861.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 56 possible false positives for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants