MINOR: [C++] Replace NULLPTR with nullptr inside registry.cc#50118
Conversation
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
|
@kou Do you think this is ok as a minor PR? |
kou
left a comment
There was a problem hiding this comment.
+1
This should not be a MINOR PR for us: https://github.com/apache/arrow/blob/main/CONTRIBUTING.md#Minor-Fixes
Could you create an issue next time?
|
Thanks, @kou. I will consider your advice. |
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit ee0d861. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 56 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
As mentioned here,
NULLPTRmust be used in headers. However,NULLPTRis used insidearrow/compute/registry.ccinstead ofnullptr.What changes are included in this PR?
Replace
NULLPTRwithnullptr.Are these changes tested?
Yes, I ran the unit tests.
Are there any user-facing changes?
No.