GH-50527: [C++] Remove ARROW_SSE4_2_FLAG for x86 MSVC#50526
Draft
loctormor wants to merge 1 commit into
Draft
Conversation
The SSE4.2 flag is invalid in for the MSVC x86 compiler. https://learn.microsoft.com/en-us/cpp/build/reference/arch-x86
|
Thanks for opening a pull request! If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project. Then could you also rename the pull request title in the following format? or See also: |
loctormor
changed the title
|
|
kou
reviewed
Jul 17, 2026
| # x86/amd64 compiler flags, msvc/gcc/clang | ||
| if(MSVC) | ||
| set(ARROW_SSE4_2_FLAG "/arch:SSE4.2") | ||
| set(ARROW_SSE4_2_FLAG "") |
Member
There was a problem hiding this comment.
Can we do this only for x86 environment?
This disables SSE 4.2 on x64 environment too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SSE4.2 flag is invalid for the MSVC x86 compiler.
https://learn.microsoft.com/en-us/cpp/build/reference/arch-x86
Rationale for this change
MSVC x86 builds generate hundreds of nuisance warnings that resemble:
cl : Command line warning D9002 : ignoring unknown option '/arch:SSE4.2'
This change aligns the flag with Microsoft documentation to remove the warnings.
What changes are included in this PR?
Simple replacement of the MSVC-specific flag "/arch:SSE4.2" with an empty string. This matches a working configuration prior to ~July 2025, at which time the flag seems to have been erroneously edited while adding xsimd definitions below.
Are these changes tested?
Yes - using cmake version 3.29.6 and a VC18 compiler.
Are there any user-facing changes?
No. This only affects developers building the source code and has no impact on the Apache Arrow libraries.