GH-50575: [CI][Dev] Fix shellcheck errors in the ci/scripts/python_wheel_xlinux_build.sh#50577
Open
hiroyuki-sato wants to merge 2 commits into
Open
Conversation
…hon_wheel_xlinux_build.sh
hiroyuki-sato
requested review from
assignUser,
jonkeane,
kou and
raulcd
as code owners
July 21, 2026 13:35
|
|
hiroyuki-sato
commented
Jul 21, 2026
| -Dxsimd_SOURCE=BUNDLED \ | ||
| ${ARROW_EXTRA_CMAKE_FLAGS} \ | ||
| -G ${CMAKE_GENERATOR} \ | ||
| "${ARROW_EXTRA_CMAKE_FLAGS}" \ |
Collaborator
Author
There was a problem hiding this comment.
ARROW_EXTRA_CMAKE_FLAGS defined here.
The name ARROW_EXTRA_CMAKE_FLAGS looks plural, but it seems to hold just a single flag
if [[ "$(uname -m)" == arm* ]] || [[ "$(uname -m)" == aarch* ]]; then
# Build jemalloc --with-lg-page=16 in order to make the wheel work on both
# 4k and 64k page arm64 systems. For more context see
# https://github.com/apache/arrow/issues/10929
export ARROW_EXTRA_CMAKE_FLAGS="-DARROW_JEMALLOC_LG_PAGE=16"
: ${ARROW_JEMALLOC:=OFF}
Member
There was a problem hiding this comment.
Could you keep accepting multiple flags?
We may use multiple flags later.
…hon_wheel_xlinux_build.sh
Collaborator
Author
|
@github-actions crossbow submit python-wheel-manylinux-2-28 python-wheel-musllinux-1-2 |
|
Member
|
@github-actions crossbow submit python-wheel-manylinux-2-28* python-wheel-musllinux-1-2* |
|
Member
|
@github-actions crossbow submit wheel-manylinux-2-28* wheel-musllinux-1-2* |
|
Revision: 1a78357 Submitted crossbow builds: ursacomputing/crossbow @ actions-9720cb735d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This is the sub issue #44748.
What changes are included in this PR?
lsiteration with globsAre these changes tested?
Yes.
Are there any user-facing changes?
No.