ARROW-11356: [Rust] Add method to PrimitiveArray::from_value to efficiently create an Array from a value#9300
Closed
Dandandan wants to merge 1 commit intoapache:masterfrom
Closed
Conversation
Member
|
Do you see any difference between this one and using the iterator? I would expect them to perform equally well, since both are using |
Contributor
Author
|
@jorgecarleitao I agree, it makes more sense to wait until this is faster and for now use the iterator for this case (even if it is slightly more verbose). |
Contributor
Author
|
Creating an null array with known size might be another that might come up in the future, but I am witholding that until it is supported by some use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In DataFusion (and probably this would pop up in more use cases) we want to efficiently create an array with
nitems with the same value (instead of creating it from a Vec of values or iterator).As discussed in here:
#9293