ATLAS-5045: [React UI] Adding detail page view for Glossary#363
Open
Brijesh619 wants to merge 1 commit into
Open
ATLAS-5045: [React UI] Adding detail page view for Glossary#363Brijesh619 wants to merge 1 commit into
Brijesh619 wants to merge 1 commit into
Conversation
Contributor
Author
|
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(ATLAS-5045 - [React UI] Adding detail page view for Glossary)
Currently, there is no detail view for the root Glossary entity like we have for Terms and Categories. This PR introduces a dedicated Glossary detail view. Additionally, this PR addresses several functional UI bugs within the Glossary module—specifically stabilizing the rich text editor—and resolves underlying test environment errors to improve the developer experience.
Glossary Editor & Form Fixes
ReactQuill "Zombie" Toolbar Bug: Fixed an issue where the rich text editor's formatting buttons (bold, italics, links, etc.) were completely unresponsive. This was resolved by updating the CSS to properly hide duplicate toolbars generated by React's StrictMode, ensuring only the active toolbar is visible and interactive.
Modal Focus Trap Bug: Resolved an issue where users were blocked from interacting with the text editor's tooltips and dropdowns (such as the "Insert Link" input). Disabled the Material-UI Modal's strict focus trap to allow seamless interaction with the editor's popups.
Form Data Hydration: Fixed a bug where the existing longDescription of a Glossary Term was failing to pre-fill into the text editor when opening the form to edit the entity.
State Mutations & Infinite Re-renders: Stabilized the React Hook Form state management to eliminate redundant value mutations and unnecessary re-renders when typing in the text editor.
General UI & Navigation Fixes
Missing Update Button: Restored the missing "Edit/Update" pencil icon on the main Glossary Detail Page so users can modify root glossaries just like they can with terms and categories.
Instant State Syncing: Fixed an issue where the interface did not update after creating or editing a Glossary, Category, or Term. The application now instantly fetches and displays the latest data upon a successful form submission without requiring a manual page refresh.
Navigation URL Bug: Resolved a routing issue that caused the @glossary suffix to be appended multiple times to the URL search parameters during navigation.
Sidebar Tree Crashes: Prevented the Glossary sidebar tree view from crashing by implementing deduplication logic, ensuring stable rendering even if duplicate node IDs are returned.
Test & Environment Fixes
IDE Module Resolution: Resolved widespread "module not found" errors in the test suite so developers no longer see false-positive path alias errors in their editors.
TypeScript Strictness: Fixed multiple strict-mode compilation errors across the testing environment (including spread parameter tuples, implicit scoping, and mocked argument definitions) to ensure the test suite is 100% compliant with the project's strict TypeScript constraints.
How was this patch tested?
manual tests
maven build