ATLAS-5207: Atlas webapp module to support rest-notification endpoint#622
Open
UmeshPatil-1 wants to merge 24 commits into
Open
ATLAS-5207: Atlas webapp module to support rest-notification endpoint#622UmeshPatil-1 wants to merge 24 commits into
UmeshPatil-1 wants to merge 24 commits into
Conversation
… rest-notification-webapp in parent pom, replacing the old private SNAPSHOT to map with parent,updated from jersy2->jersy1, Removed Servlet 4.0-only methods that are not on ServletContext in Servlet 3.1 (they were breaking @OverRide) etc
…sses from webapp and rest-notification webapp, updated imports to use server-common module,updated paren pom and xml wiring's etc.
….ServletException and in rest-notification webapp NullServletContext method does not override or implement a method from a supertype, these was because javax.servlet-api 3.1 and there is no support for methods which are using servlet-4.0.
…app in server-common module.
…ebapp and rest-notification-webapp and Updating method visibility to resolve compile time error for UserDaoTest (testMergePasswordAndSalt_EmptySalt) method.
…h webapp and rest-notification webapp.
… both webapp and rest-notification webapp.
…both webapp and rest-notification webapp.
…both webapp and rest-notification webapp.
…rver-common module.
…common module for both webapp and rest-notification webapp.
…d redundant lines.
…rn; align WebappAdminAuditHookTest with long resultCount
…ile-gate test security, split filter beans, Curator only if HA.
…nd rest-notification module.
|
|
||
| ####### Atlas REST Notification ########### | ||
|
|
||
| atlas.hook.rest.notification.address=http://atlas-rest.example.com:41000/rest |
Contributor
There was a problem hiding this comment.
Please comment the rest-notification properties.
|
|
||
| ####### Atlas REST Notification ########### | ||
|
|
||
| atlas.hook.rest.notification.address=http://atlas-rest.example.com:41000/rest |
Contributor
There was a problem hiding this comment.
| * to you under the Apache License, Version 2.0 (the | ||
| * "License"); you may not use this file except in compliance | ||
| * with the License. You may obtain a copy of the License at | ||
| * <p> |
Contributor
There was a problem hiding this comment.
Class should be RestNotificationHighAvailabilityImpl please check the internal branch class name
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class AtlasSecurityStateProviderConfig { |
Contributor
There was a problem hiding this comment.
Check the internal branch class name AtlasServiceStateProviderConfig
| </dependencies> | ||
|
|
||
| <build> | ||
| <plugins> |
Contributor
There was a problem hiding this comment.
Please check the build plugins with the internal branch rest-notification pom.xml file.
| * Webapp implementation of {@link HighAvailabilitySupport} using {@link HAConfiguration}. | ||
| */ | ||
| @Component | ||
| public class WebappHighAvailabilitySupport implements HighAvailabilitySupport { |
Contributor
There was a problem hiding this comment.
Change the name HighAvailabilityImpl, please check the internal code
| * and do not rely on {@link org.apache.atlas.RequestContext} during bootstrap. | ||
| */ | ||
| @Component | ||
| public class WebappAdminAuditHook implements ServiceMetricsHook { |
Contributor
There was a problem hiding this comment.
Please check the internal branch class name ServiceStateChangeAuditHandler and it code
| * Bridges {@link ServiceMetricsHook} to {@link AtlasMetricsUtil} in the main webapp. | ||
| */ | ||
| @Component | ||
| public class WebappServiceMetricsHook implements ServiceMetricsHook { |
Contributor
There was a problem hiding this comment.
check the internal code ServiceStateChangeMetricHandler
| import org.springframework.context.annotation.Configuration; | ||
|
|
||
| @Configuration | ||
| public class AtlasSecurityStateProviderConfig { |
Contributor
There was a problem hiding this comment.
Class is different in internal branch AtlasServiceStateProviderConfig
| hook = new WebappAdminAuditHook(auditService); | ||
| } | ||
|
|
||
| @Test |
Contributor
There was a problem hiding this comment.
Check this test will fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix. Create an issue in ASF JIRA before opening a pull request and
set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. ATLAS-XXXX: Fix a typo in YYY))
How was this patch tested?
(Please explain how this patch was tested. Ex: unit tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)