[AURON #2407] [BUILD] Fix the invalid Spark 4.1 Docker build example.#2408
[AURON #2407] [BUILD] Fix the invalid Spark 4.1 Docker build example.#2408slfan1989 wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the build documentation and auron-build.sh --help output to provide valid, Spark-version-specific Docker build examples (notably avoiding Spark 4.x with centos7/JDK 8 and excluding incompatible integrations), and adds a documented compatibility matrix for contributors.
Changes:
- Update
CONTRIBUTING.mdDocker example to userockylinux8and add a build compatibility matrix covering Spark/Scala/JDK/image and integration combinations. - Update
auron-build.sh --helpto print separate Docker build examples for Spark 3.5, 4.0, and 4.1 with compatible Scala/JDK/image/integration selections.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| CONTRIBUTING.md | Updates Docker build example and adds a build compatibility matrix documenting supported combinations. |
| auron-build.sh | Replaces the single Docker example in --help with explicit, Spark-version-specific Docker build examples. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" \ | ||
| "--hudi ${SUPPORTED_HUDI_VERSIONS[*]: -1}" |
There was a problem hiding this comment.
Fixed. The Spark 3.5 example now uses explicitly pinned integration versions that match the compatibility matrix, including Iceberg 1.10.1 and Hudi 0.15. I also pinned the other integration versions to prevent the example from changing when the supported-version arrays are reordered or extended.
| "--celeborn ${SUPPORTED_CELEBORN_VERSIONS[*]: -1}" \ | ||
| "--uniffle ${SUPPORTED_UNIFFLE_VERSIONS[*]: -1}" \ | ||
| "--paimon ${SUPPORTED_PAIMON_VERSIONS[*]: -1}" \ | ||
| "--iceberg ${SUPPORTED_ICEBERG_VERSIONS[*]: -1}" |
There was a problem hiding this comment.
Fixed. The Spark 4.0 example now explicitly uses Iceberg 1.10.1, consistent with the compatibility matrix. The other integration versions in the example have also been pinned to keep the help output stable.
…ample. Signed-off-by: slfan1989 <slfan1989@apache.org>
| ### Build Compatibility Matrix | ||
|
|
||
| The examples printed by `./auron-build.sh --help` use the following documented build | ||
| configurations based on the current compatibility checks. A dash (`—`) means that the | ||
| integration is not supported for that Spark version and must not be passed to | ||
| `auron-build.sh`. |
| echo " # Spark 3.5 with all supported third-party integrations" | ||
| echo " $0 --docker true --image rockylinux8" \ | ||
| "--clean true --skiptests true --release" \ |
Which issue does this PR close?
Closes #2407
Rationale for this change
The Docker build example generated by
auron-build.sh --helpused Spark 4.1 together with thecentos7image.The
centos7image only provides JDK 8, while Spark 4.x requires JDK 17 or later. The example also enabled Iceberg and Hudi for Spark versions with which those integrations are not compatible.As a result, users following the documented example encountered Java version or integration compatibility errors before completing the build.
What changes are included in this PR?
Spark 3.5, Spark 4.0, and Spark 4.1.
rockylinux8image for these examples because it supports theJDK selection required by Spark 4.x.
CONTRIBUTING.md.Uniffle, Paimon, Iceberg, and Hudi combinations.
CONTRIBUTING.mdto userockylinux8.be updated together.
Are there any user-facing changes?
Yes.
The help output now provides separate Docker build examples for Spark
3.5, Spark 4.0, and Spark 4.1. Each example uses an appropriate Scala,
JDK, Docker image, and third-party integration combination.
Contributors can also consult the compatibility matrix in
CONTRIBUTING.mdbefore selecting build arguments.How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
If yes, include:
Generated-by: <tool name and version>ASF guidance: https://www.apache.org/legal/generative-tooling.html