Commiting Unit Test with Failing Byte Array Deserialization#293
Conversation
|
Hi @martin-g I added the recommended changes. Please let me know if this works. |
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
…lib.rs Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
Signed-off-by: Martin Tzvetanov Grigorov <mgrigorov@apache.org>
There was a problem hiding this comment.
Pull Request Overview
This PR adds unit tests to demonstrate a bug with byte array deserialization in the Apache Avro library, as referenced in issue #285. The changes include comprehensive test cases and documentation to help reproduce and understand the problem.
- Adds failing unit tests for byte array deserialization scenarios
- Provides documentation and examples for proper byte array handling with Serde
- Includes both complete and filtered deserialization test cases to isolate the issue
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| avro/tests/avro-rs-285-bytes_deserialization.rs | New test file with comprehensive unit tests demonstrating the byte array deserialization bug |
| avro/src/lib.rs | Documentation section explaining proper Serde usage for byte arrays with detailed examples |
| avro/README.md | User-facing documentation with examples of byte array deserialization patterns |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
Hi @martin-g , apologies for the drop off. Is there anything else you need on my end for the doc updates? |
No! I postponed the merge of few no high prio PRs like this one because of our work on Async APIs (#238). This PR will be merged for the next release! With or without the Async APIs. |
|
Awesome thank you @martin-g ! This is an awesome crate, and I greatly appreciate all the work you put in to keep it maintained. |
|
Thank you, @roofdiver ! |
Hi! This is related to #285. I've added a small example file and details in the unit tests