Skip to content

[Dataflow Streaming] Fix spammy log during GrpcGetDataStream physical stream half-closing #38158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
scwhittle wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −1
Open

[Dataflow Streaming] Fix spammy log during GrpcGetDataStream physical stream half-closing #38158

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .../java/org/apache/beam/runners/dataflow/worker/windmill/client/grpc/GrpcGetDataStream.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,12 +226,15 @@ public void onResponse(StreamingGetDataResponse chunk) {

@Override
public boolean hasPendingRequests() {
// Note the batchesSizeSupplier may reflect batches that could be sent on another physical
// stream. However we treat them as possibly pending on all physical streams to ensure that we
// recreate streams to send them.
return !pending.isEmpty() || batchesSizeSupplier.get() > 0;
}

@Override
public void onDone(Status status) {
if (status.isOk() && hasPendingRequests()) {
if (status.isOk() && !pending.isEmpty()) {
LOG.warn("Pending requests not expected on successful GetData stream flushing.");
}
for (AppendableInputStream responseStream : pending.values()) {
Expand Down
Loading