Cherry-pick PR #37954 into 2.73 release#38168
Cherry-pick PR #37954 into 2.73 release#38168acrites wants to merge 1 commit intoapache:release-2.73from
Conversation
…lass. (apache#37954) * Moves applied finalize ids out of windmill WorkItem proto since that field isn't present in internal version. Moves it to AssembledWorkItem. Also adds internal GetWorkResponse.applied_finalize_ids, which is used by Appliance, so now validates runner tests pass. * Reserves previously used proto field and manually triggers post submits.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors how finalize IDs are handled within the Dataflow worker. By moving these IDs from the WorkItem proto to the GetWorkResponse proto and integrating them into the AssembledWorkItem class, the changes improve compatibility with internal versions and ensure that finalize callbacks are correctly executed by the Streaming Engine. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Moves finalize ids out of WorkItem proto and into AssembledWorkItem class:
Moves applied finalize ids out of windmill WorkItem proto since that field isn't present in internal version. Moves it to AssembledWorkItem. Also adds internal GetWorkResponse.applied_finalize_ids, which is used by Appliance, so now validates runner tests pass.
Reserves previously used proto field and manually triggers post submits.
This is part of a fix of changes in PR #37723.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.