Fix BigQuery Storage Write API stream count for bounded writes#38776
Fix BigQuery Storage Write API stream count for bounded writes#38776Akshatsharma2205 wants to merge 2 commits into
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request expands the functionality of the BigQuery Storage Write API by allowing the number of write streams to be configured for bounded (batch) writes, in addition to the existing support for unbounded (streaming) writes. The changes ensure that stream count configurations are applied consistently across different pipeline types while maintaining existing constraints on triggering frequency and auto-sharding for streaming data. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request enables the use of fixed stream counts (numStreams) for both batch (bounded) and streaming (unbounded) pipelines in the BigQuery Storage Write API, updating the Java and Python SDKs as well as the documentation. The review feedback suggests validating that numStreams is non-negative to prevent silent configuration errors, and simplifying the conditional check once validation is in place.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| PCollection<Row> inputRows = input.getSinglePCollection(); | ||
|
|
||
| BigQueryIO.Write<Row> write = createStorageWriteApiTransform(inputRows.getSchema()); | ||
| int numStreams = configuration.getNumStreams() == null ? 0 : configuration.getNumStreams(); |
There was a problem hiding this comment.
If configuration.getNumStreams() is configured with a negative value, it will be silently ignored and treated as 0 (which enables auto-sharding if unbounded, or default behavior if bounded). We should validate that numStreams is non-negative and throw an IllegalArgumentException if it is negative to prevent silent configuration errors.
int numStreams = configuration.getNumStreams() == null ? 0 : configuration.getNumStreams();
if (numStreams < 0) {
throw new IllegalArgumentException("numStreams must be non-negative, but was: " + numStreams);
}There was a problem hiding this comment.
Thanks for the suggestion. I added validation for negative numStreams in BigQueryWriteConfiguration.validate() using the existing checkArgument style.
| if (numStreams > 0) { | ||
| write = write.withNumStorageWriteApiStreams(numStreams); | ||
| } else if (autoSharding == null || autoSharding) { | ||
| if (numStreams <= 0 && (autoSharding == null || autoSharding)) { |
There was a problem hiding this comment.
Since numStreams is validated to be non-negative, we can simplify numStreams <= 0 to numStreams == 0 for better clarity.
| if (numStreams <= 0 && (autoSharding == null || autoSharding)) { | |
| if (numStreams == 0 && (autoSharding == null || autoSharding)) { |
There was a problem hiding this comment.
Updated in the latest commit. Since numStreams is now validated to be non-negative, the auto-sharding condition uses numStreams == 0.
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
|
The failing/cancelled checks appear unrelated to this PR. I checked the visible annotations and did not see failures mentioning the changed BigQuery files or docs. Several failures are in Python ML/anomaly/RAG tests or CI timeouts. Could the failed/cancelled checks be rerun when convenient? |
1 participant
Summary
Fixes #38770
Validation
git diff --checksuccessfully../gradlew :sdks:java:io:google-cloud-platform:compileJavalocally, but the build did not reach Java compilation because this was prepared from a sparse checkout missing Beam build plugin infrastructure.Key Gradle error:
Java compilation did not start.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.