Skip to content

pin commons-configuration2 version to 2.15.0 #38779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
derrickaw wants to merge 4 commits into
base: master
Choose a base branch
from
+13 −1
Draft

pin commons-configuration2 version to 2.15.0 #38779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c88425
pin commons-configuration2 version
derrickaw Jun 2, 2026
024c3ee
add on commons-io pin
derrickaw Jun 2, 2026
e8b658d
change commons-io pinning to global
derrickaw Jun 2, 2026
3bc1205
remove split
derrickaw Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ class BeamModulePlugin implements Plugin<Project> {
commons_collections : "commons-collections:commons-collections:3.2.2",
commons_compress : "org.apache.commons:commons-compress:1.26.2",
commons_csv : "org.apache.commons:commons-csv:1.8",
commons_io : "commons-io:commons-io:2.16.1",
commons_io : "commons-io:commons-io:2.19.0",
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Define commons_configuration2 centrally in BeamModulePlugin.groovy so that it can be referenced across subprojects (like hbase and iceberg) instead of hardcoding the version string in multiple places.

        commons_configuration2                      : "org.apache.commons:commons-configuration2:2.15.0",
        commons_io                                  : "commons-io:commons-io:2.19.0",

commons_lang3 : "org.apache.commons:commons-lang3:3.18.0",
commons_logging : "commons-logging:commons-logging:1.2",
commons_math3 : "org.apache.commons:commons-math3:3.6.1",
Expand Down
8 changes: 8 additions & 0 deletions sdks/java/io/hbase/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,3 +50,11 @@ dependencies {
testImplementation("org.apache.hbase:hbase-shaded-testing-util:$hbase_version")
testRuntimeOnly project(path: ":runners:direct-java", configuration: "shadow")
}

configurations.all {
resolutionStrategy {
// TODO: remove after higher version of hbase (>2.6.5) contains this minimum version.
force 'org.apache.commons:commons-configuration2:2.15.0'
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain centralized dependency management, avoid hardcoding the dependency coordinates and version here. Instead, reference the centralized dependency from BeamModulePlugin.groovy using library.java.commons_configuration2.

    force library.java.commons_configuration2

}
}

4 changes: 4 additions & 0 deletions sdks/java/io/iceberg/hive/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,4 +78,8 @@ dependencies {
configurations.all {
// the fatjar "parquet-hadoop-bundle" conflicts with "parquet-hadoop" used by org.apache.iceberg:iceberg-parquet
exclude group: "org.apache.parquet", module: "parquet-hadoop-bundle"
// TODO: remove after higher version of hbase (>2.6.5) contains this minimum version.
resolutionStrategy {
force 'org.apache.commons:commons-configuration2:2.15.0'
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain centralized dependency management, avoid hardcoding the dependency coordinates and version here. Instead, reference the centralized dependency from BeamModulePlugin.groovy using library.java.commons_configuration2.

        force library.java.commons_configuration2

}
}
Loading