Fix cloudML TFT install avoiding pip ResolutionTooDeep#38781
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves installation failures in the CloudML benchmark suite caused by complex dependency resolution during the pip installation process. By decoupling the installation of tensorflow-transform from the primary requirements file, the build process is stabilized, ensuring consistent environment preparation for dataflow tests. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request triggers the CloudML Benchmarks Dataflow test suite and updates the installTFTRequirements task in common.gradle to install tensorflow-transform separately with --no-deps after filtering it out of the base requirements. Feedback suggests avoiding the hardcoded temporary file path /tmp/cloudml_tft_base_requirements.txt to prevent potential conflicts or race conditions, recommending the use of mktemp for a unique temporary file instead.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| args '-c', ". ${envdir}/bin/activate && " + | ||
| "grep -v '^tensorflow-transform' requirements.txt > /tmp/cloudml_tft_base_requirements.txt && " + | ||
| "pip install -r /tmp/cloudml_tft_base_requirements.txt && " + | ||
| "pip install --no-deps tensorflow-transform==1.16.0" |
There was a problem hiding this comment.
Using a hardcoded temporary file path like /tmp/cloudml_tft_base_requirements.txt can lead to conflicts, permission issues, or race conditions if multiple builds or tasks run concurrently on the same machine.
It is safer to use mktemp to create a unique temporary file and ensure it is cleaned up after the installation is complete.
args '-c', ". ${envdir}/bin/activate && " +
'tmp_file=$(mktemp) && ' +
'grep -v "^tensorflow-transform" requirements.txt > "$tmp_file" && ' +
'pip install -r "$tmp_file" && ' +
'rm "$tmp_file" && ' +
'pip install --no-deps tensorflow-transform==1.16.0'
|
Assigning reviewers: R: @claudevdm for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Fixes: #38780
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.