Skip to content

defer ConstructionTimeTest fixtures to setUpClass #38835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
aIbrahiim wants to merge 1 commit into
base: master
Choose a base branch
from
+18 −14
Draft

defer ConstructionTimeTest fixtures to setUpClass #38835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/trigger_files/beam_PostCommit_XVR_Direct.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"modification": 1
"modification": 2
}
30 changes: 17 additions & 13 deletions sdks/python/apache_beam/dataframe/frames_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2957,17 +2957,21 @@ def test_allow_non_parallel_nesting(self):

class ConstructionTimeTest(unittest.TestCase):
"""Tests for operations that can be executed eagerly."""
DF = pd.DataFrame({
'str_col': ['foo', 'bar'] * 3,
'int_col': [1, 2] * 3,
'flt_col': [1.1, 2.2] * 3,
'cat_col': pd.Series(list('aabbca'), dtype="category"),
'datetime_col': pd.Series(
pd.date_range(
'1/1/2000', periods=6, freq='m', tz='America/Los_Angeles'))
})
DEFERRED_DF = frame_base.DeferredFrame.wrap(
expressions.PlaceholderExpression(DF.iloc[:0]))
_DF_COLUMNS = ('str_col', 'int_col', 'flt_col', 'cat_col', 'datetime_col')

@classmethod
def setUpClass(cls):
cls.DF = pd.DataFrame({
'str_col': ['foo', 'bar'] * 3,
'int_col': [1, 2] * 3,
'flt_col': [1.1, 2.2] * 3,
'cat_col': pd.Series(list('aabbca'), dtype="category"),
'datetime_col': pd.Series(
pd.date_range(
'1/1/2000', periods=6, freq='m', tz='America/Los_Angeles'))
})
cls.DEFERRED_DF = frame_base.DeferredFrame.wrap(
expressions.PlaceholderExpression(cls.DF.iloc[:0]))

def _run_test(self, fn):
expected = fn(self.DF)
Expand All @@ -2982,11 +2986,11 @@ def _run_test(self, fn):
else:
self.assertEqual(expected, actual)

@parameterized.expand(DF.columns)
@parameterized.expand(_DF_COLUMNS)
def test_series_name(self, col_name):
self._run_test(lambda df: df[col_name].name)

@parameterized.expand(DF.columns)
@parameterized.expand(_DF_COLUMNS)
def test_series_dtype(self, col_name):
self._run_test(lambda df: df[col_name].dtype)
self._run_test(lambda df: df[col_name].dtypes)
Expand Down
Loading