improving unit test coverage (WIP) by uruwhy · Pull Request #3246 · apache/caldera

uruwhy · 2026-01-22T19:38:42Z

Description

address most unit test warnings
add additional unit tests to boost code coverage to
minor base code refactoring and adjustments to remove unused code or to allow unit testing on certain components

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Ran tests to confirm coverage

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
I have added tests that prove my fix is effective or that my feature works

…ct unit tests

sonarqubecloud · 2026-01-28T13:03:37Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

jlklos

Tested the code locally and confirmed Caldera core runs well both with and without plugins enabled. Ran coverage tests locally and confirmed Sonarqube results. Local coverage test reports overall code coverage at 85%.

+    }
+    if url == 'https://api.github.com/gists':
+        mock_data = MOCK_GISTS
+    elif url.startswith('https://gist.githubusercontent.com'):


+            raise web.HTTPNotFound(text='File not found')
        except Exception as e:
-            return web.HTTPNotFound(body=str(e))
+            raise web.HTTPNotFound(text=str(e))


-    def _request_errors(request):
-        errors = []
-        return errors
+                raise web.HTTPNotFound(text=str(e))


sonarqubecloud · 2026-05-19T13:09:07Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
93.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

uruwhy · 2026-05-21T13:52:07Z

    async def delete_ability(self, request: web.Request):
        await self.delete_on_disk_object(request)
-        return web.HTTPNoContent()
+        raise web.HTTPNoContent()


Suggested change

raise web.HTTPNoContent()

return web.HTTPNoContent()

revert for now

uruwhy · 2026-05-21T13:52:26Z

        except PermissionError:
            response = web.HTTPForbidden(reason="Permission denied.")
-        return response
+        raise response


Suggested change

raise response

return response

revert for now

uruwhy · 2026-05-21T13:52:48Z

            return web.Response(body=content, headers=headers)
        except FileNotFoundError:
-            return web.HTTPNotFound(body='File not found')
+            raise web.HTTPNotFound(text='File not found')


Suggested change

raise web.HTTPNotFound(text='File not found')

return web.HTTPNotFound(text='File not found')

revert for now

uruwhy · 2026-05-21T13:53:01Z

+            raise web.HTTPNotFound(text='File not found')
        except Exception as e:
-            return web.HTTPNotFound(body=str(e))
+            raise web.HTTPNotFound(text=str(e))


Suggested change

raise web.HTTPNotFound(text=str(e))

return web.HTTPNotFound(text=str(e))

revert for now

uruwhy · 2026-05-21T13:53:49Z

    async def process(*args, **kwargs):
        async with aiohttp.ClientSession(headers=dict(Authorization='token {}'.format(args[0].token)),
-                                         connector=aiohttp.TCPConnector(verify_ssl=False)) as session:
+                                         connector=aiohttp.TCPConnector(ssl=False)) as session:


Suggested change

connector=aiohttp.TCPConnector(ssl=False)) as session:

connector=aiohttp.TCPConnector(verify_ssl=False)) as session:

revert for now

uruwhy · 2026-05-21T13:54:20Z

    async def process(*args, **kwargs):
        async with aiohttp.ClientSession(headers=dict(Authorization='Bearer {}'.format(args[0].key)),
-                                         connector=aiohttp.TCPConnector(verify_ssl=False)) as session:
+                                         connector=aiohttp.TCPConnector(ssl=False)) as session:


Suggested change

connector=aiohttp.TCPConnector(ssl=False)) as session:

connector=aiohttp.TCPConnector(verify_ssl=False)) as session:

revert for now

deacon-mp · 2026-05-21T14:21:36Z

Replace the mocked path in tests/services/test_data_svc.py with a safe path under data/

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

uruwhy added 30 commits January 10, 2026 00:02

use original make_app func to include in test coverage

5100c8b

add ability delete unit test

cd1c7a5

remove unused imports

b4bdc89

restructure ascii banner exports for unit testing

40ad380

unit tests for banner

bfbef86

payload encoder unit tests

f72a7bc

remove unused code

c7f459a

permit file upload outside of operation

433f257

additional rest api tests

ce8d68a

app service unit tests

f5aadfc

HTTP contact beacon unit test

38fb9c5

improve str function for DNS helper classes, add more unit tests

5f39102

make sure FTP contact writes files in binary mode, add more FTP conta…

874e594

…ct unit tests

remove dead code

da29139

remaining unit tests

153052c

style fixes

1731eb0

remove dead code

0798080

restructure fixtures, add more tests

207e2a1

style fix

3075f57

add failure case log message

c15f77e

more dns contact unit tests

4ced90e

style fix

e5457ec

adding config API unit tests

54a6cc2

restructure code for unit testing

bf3ae72

add HTML contact unit test

865bb88

add instruction

4d736ba

add test op summary

47698ed

add base obfuscator unit test

a6d02a7

add variation eq

7489f88

add missing executor unit tests

7092955

uruwhy added 10 commits January 18, 2026 05:52

properly await function

a202757

raise response

db69116

address deprecated warnings

e69b354

more unit tests, address warnings

d1b1013

Merge branch 'master' into coverage-a

e9b3254

raise HTTP exceptions instead of returning them

1e6c801

additional unit tests

62aadaf

address ssl warning

423ad3f

slack contact unit tests

c831656

adjust utc timezone fetch

62ef268

jlklos previously approved these changes Feb 4, 2026

View reviewed changes

uruwhy added 3 commits May 5, 2026 02:17

fix tests

70a37d8

Merge branch 'master' into coverage-a

a094f9b

adjust post-merge

ba8d98b

uruwhy dismissed jlklos’s stale review via a094f9b May 15, 2026 12:11

uruwhy marked this pull request as ready for review May 15, 2026 15:37

Merge branch 'master' into coverage-a

45aaaa5

github-advanced-security AI found potential problems May 19, 2026

View reviewed changes

uruwhy commented May 21, 2026

View reviewed changes

deacon-mp requested a review from Copilot May 21, 2026 14:23

Copilot started reviewing on behalf of deacon-mp May 21, 2026 14:23 View session

Copilot AI reviewed May 21, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

improving unit test coverage (WIP)#3246

improving unit test coverage (WIP)#3246
uruwhy wants to merge 50 commits into
masterfrom
coverage-a

uruwhy commented Jan 22, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Jan 28, 2026

Uh oh!

jlklos left a comment •

edited

Loading

Uh oh!

sonarqubecloud Bot commented May 19, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

uruwhy May 21, 2026

Uh oh!

deacon-mp commented May 21, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	raise web.HTTPNotFound(text='File not found')
	return web.HTTPNotFound(text='File not found')

	raise web.HTTPNotFound(text=str(e))
	return web.HTTPNotFound(text=str(e))

	connector=aiohttp.TCPConnector(ssl=False)) as session:
	connector=aiohttp.TCPConnector(verify_ssl=False)) as session:

Conversation

uruwhy commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

sonarqubecloud Bot commented Jan 28, 2026

Quality Gate passed

Uh oh!

jlklos left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud Bot commented May 19, 2026

Quality Gate passed

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

uruwhy May 21, 2026

Choose a reason for hiding this comment

Uh oh!

deacon-mp commented May 21, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

uruwhy commented Jan 22, 2026 •

edited

Loading

jlklos left a comment •

edited

Loading