Skip to content

Closes #6195: Add integration tests for Saga example #486

Closed
jomin7 wants to merge 3 commits intoapache:mainfrom
jomin7:6195-saga-example-tests
Closed

Closes #6195: Add integration tests for Saga example #486
jomin7 wants to merge 3 commits intoapache:mainfrom
jomin7:6195-saga-example-tests

Conversation

@jomin7
Copy link
Copy Markdown

@jomin7 jomin7 commented Mar 24, 2026

Closes apache/camel-quarkus#6195: Add integration tests for Saga example

Created saga-integration-tests module with comprehensive test coverage for the Saga/LRA example demonstrating distributed transaction coordination using Testcontainers.

Changes:

  • New saga-integration-tests module with 4 integration tests
  • Tests verify LRA coordination, JMS messaging, and service participation
  • Testcontainers manages Artemis broker and LRA coordinator lifecycle
  • Improved container wait strategies (HTTP health check vs log matching)
  • Added JMS request-timeout configuration (5s) to prevent test timeouts
  • Updated main README.adoc with testing documentation
  • Comprehensive README.md in saga-integration-tests module

…gration-tests module with comprehensive test coverage for the Saga/LRA example demonstrating distributed transaction coordination using Testcontainers. Changes: - New saga-integration-tests module with 4 integration tests - Tests verify LRA coordination, JMS messaging, and service participation - Testcontainers manages Artemis broker and LRA coordinator lifecycle - Improved container wait strategies (HTTP health check vs log matching) - Added JMS request-timeout configuration (5s) to prevent test timeouts - Updated main README.adoc with testing documentation - Comprehensive README.md in saga-integration-tests module
@jomin7 jomin7 changed the title Fixes #6195: Add integration tests for Saga example Closes #6195: Add integration tests for Saga example Mar 24, 2026
@jamesnetherton
Copy link
Copy Markdown
Contributor

I wonder if we could avoid duplication of the routes and app config if we added the saga apps as dependencies on the itest module?

@jomin7
Copy link
Copy Markdown
Author

jomin7 commented Mar 24, 2026

Thanks for the suggestion @jamesnetherton . I can definitely try refactor it that way.
Best Regards
Jomin

…ion tests

  - Added service modules as dependencies to saga-integration-tests
  - Deleted duplicate routes and config from saga-integration-tests/src/main
  - Added jandex plugin for CDI bean indexing
  - Code review fixes: removed dead dependency, fixed docs, added timeout comments
@jomin7
Copy link
Copy Markdown
Author

jomin7 commented Mar 24, 2026

Addressed review comments

  • Refactor: Used dependencies instead of duplicating routes in saga-integration-tests.
  • Build: Added jandex plugin for CDI bean indexing.
  • Review Fixes: Removed dead dependencies, updated docs, and added timeout comments.

@jamesnetherton
Copy link
Copy Markdown
Contributor

@jomin7 please add a maven profile to the integration test module like this one:

https://github.com/apache/camel-quarkus-examples/blob/main/kafka/pom.xml#L361-L371

It's required because there is no Docker on GitHub Windows runners.

@jomin7
Copy link
Copy Markdown
Author

jomin7 commented Mar 25, 2026

Thank you for the feedback @jamesnetherton and for sharing the reference. I'll look into implementing the profile now.

@jamesnetherton
Copy link
Copy Markdown
Contributor

Thanks @jomin7 It LGTM. I will hold merging this until we're done with the final 3.33.0 release activities later today.

@jomin7
Copy link
Copy Markdown
Author

jomin7 commented Mar 25, 2026

Maven profile added to skip Testcontainers-based tests for environments without Docker support

@jomin7
Copy link
Copy Markdown
Author

jomin7 commented Mar 25, 2026

Thanks @jomin7 It LGTM. I will hold merging this until we're done with the final 3.33.0 release activities later today.

Thanks for the review @jamesnetherton

@jamesnetherton
Copy link
Copy Markdown
Contributor

Superseded by #489.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests in camel-quarkus-example saga

2 participants