Closes #6195: Add integration tests for Saga example #486
Closes #6195: Add integration tests for Saga example #486jomin7 wants to merge 3 commits intoapache:mainfrom
Conversation
…gration-tests module with comprehensive test coverage for the Saga/LRA example demonstrating distributed transaction coordination using Testcontainers. Changes: - New saga-integration-tests module with 4 integration tests - Tests verify LRA coordination, JMS messaging, and service participation - Testcontainers manages Artemis broker and LRA coordinator lifecycle - Improved container wait strategies (HTTP health check vs log matching) - Added JMS request-timeout configuration (5s) to prevent test timeouts - Updated main README.adoc with testing documentation - Comprehensive README.md in saga-integration-tests module
|
I wonder if we could avoid duplication of the routes and app config if we added the saga apps as dependencies on the itest module? |
|
Thanks for the suggestion @jamesnetherton . I can definitely try refactor it that way. |
…ion tests - Added service modules as dependencies to saga-integration-tests - Deleted duplicate routes and config from saga-integration-tests/src/main - Added jandex plugin for CDI bean indexing - Code review fixes: removed dead dependency, fixed docs, added timeout comments
|
Addressed review comments
|
|
@jomin7 please add a maven profile to the integration test module like this one: https://github.com/apache/camel-quarkus-examples/blob/main/kafka/pom.xml#L361-L371 It's required because there is no Docker on GitHub Windows runners. |
|
Thank you for the feedback @jamesnetherton and for sharing the reference. I'll look into implementing the profile now. |
|
Thanks @jomin7 It LGTM. I will hold merging this until we're done with the final 3.33.0 release activities later today. |
|
Maven profile added to skip Testcontainers-based tests for environments without Docker support |
Thanks for the review @jamesnetherton |
|
Superseded by #489. |
Closes apache/camel-quarkus#6195: Add integration tests for Saga example
Created saga-integration-tests module with comprehensive test coverage for the Saga/LRA example demonstrating distributed transaction coordination using Testcontainers.
Changes: