registering common Camel types used in onException for refle…#8505
registering common Camel types used in onException for refle…#8505aldettinger merged 1 commit intoapache:mainfrom
Conversation
...tests/netty/src/main/java/org/apache/camel/quarkus/component/netty/tcp/NettyTcpResource.java
Outdated
Show resolved
Hide resolved
...oyment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java
Outdated
Show resolved
Hide resolved
d32473c to
4f59682
Compare
...oyment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelNativeImageProcessor.java
Outdated
Show resolved
Hide resolved
4f59682 to
6eb4d09
Compare
|
There is a question whether It would be good to have other advice here. |
|
Sorry @JinyuChen97 , I merge the following PR and it could conflict with your changes. |
Yeah I think #8508 mostly supersedes this. What we could do instead in this PR, is search the codebase for usages of: ExchangeTimedOutException And remove any native reflection configuration and verify that the native tests continue to pass. |
6eb4d09 to
8f674c2
Compare
Verified exception class registration using onException test. All exceptions are now auto-registered by the code change from #8508. The onException test handlers were removed after verification. |
|
Don't we have more to cover like in |
oh yes, you are right, this exception is used by onException(class) pattern, so it can be removed as well. integration-tests/servlet/src/main/java/org/apache/camel/quarkus/component/servlet/CustomException.java integration-test-groups/http/netty-http/src/main/java/org/apache/camel/quarkus/component/http/netty/NettyHttpRoutes.java integration-tests-support/messaging/common/src/main/java/org/apache/camel/quarkus/component/messaging/it/MessagingCommonRoutes.java please suggest if you found more. And should we investigate the solution of adding throwException(new class) or leave them at the moment? |
8f674c2 to
774627e
Compare
774627e to
739e308
Compare
|
Yes, there are probably more, a general review is probably needed. And maybe we could have in other DSLs, like xml dsl. Concerning |
|
Well, I think `throwException` is supported as well.
Alexandre Gallice ***@***.***> 于2026年4月9日周四 22:39写道:
… *aldettinger* left a comment (apache/camel-quarkus#8505)
<#8505 (comment)>
Yes, there are probably more, a general review is probably needed. And
maybe we could have in other DSLs, like xml dsl. Concerning throwException,
it might be out of scope of this pr, maybe it could be separated to another
ticket.
—
Reply to this email directly, view it on GitHub
<#8505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
throwException(Class) is supported, but the way like throwException(new instance) seems not supported , please correct me if i'm wrong. |
|
Hmm, yeah, that could be the case. throwException(new instance) might not
match the bytecode pattern. Feel free to invesigate it further if you like.
JinyuChen97 ***@***.***> 于2026年4月9日周四 23:08写道:
… *JinyuChen97* left a comment (apache/camel-quarkus#8505)
<#8505 (comment)>
Well, I think throwException is supported as well. Alexandre Gallice *@*.
*> 于2026年4月9日周四 22:39写道: … <#m_987960130342204388_> aldettinger left a
comment (apache/camel-quarkus#8505
<#8505>) <#8505 (comment)
<#8505 (comment)>>
Yes, there are probably more, a general review is probably needed. And
maybe we could have in other DSLs, like xml dsl. Concerning throwException,
it might be out of scope of this pr, maybe it could be separated to another
ticket. — Reply to this email directly, view it on GitHub <#8505 (comment)
<#8505 (comment)>>,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU
<https://github.com/notifications/unsubscribe-auth/AAJQHOYOK4F3T6H4V6YLBG34U6YYTAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGA4TONJVGU>
. You are receiving this because you were mentioned.Message ID: @.*>
throwException(Class) is supported, but the way like throwException(new
instance) seems not supported , please correct me if i'm wrong.
—
Reply to this email directly, view it on GitHub
<#8505 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJQHOZ2GA4MFDKPYJ5D5634U64GBAVCNFSM6AAAAACXPN7BQ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHM2DEMJVGI4DGNZSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Yes, that could be the scope of another ticket, created #8512. Thanks all for great collective work on this subject 👍 |
|
@aldettinger is this good to merge? |
|
Not sure yet. What about |
Seems that was taken care of in 76f2ba2. |
|
And a last one is This one is also used to test |
hmmm, I think I have removed it? (The main-yaml/CustomException in the change) it's the one used in yaml dsl. |
|
@JinyuChen97 It's right, things were mixed up on my machine. Sorry, for the noise. |
fixes #7608
Found several common Camel exceptions that are frequently used in onException() handlers across multiple extensions. These are now registered centrally in camel-quarkus-core to avoid duplication and prevent ClassNotFoundException in native mode.