Skip to content

CAMEL-24057: check actually-used classes in @ConditionalOnClass for access log configurations #1850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Croway merged 1 commit into from
Jul 15, 2026
+14 −3
Merged

CAMEL-24057: check actually-used classes in @ConditionalOnClass for access log configurations #1850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e/camel/component/platform/http/springboot/customizer/UndertowAccessLogConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,11 @@
*/
@Configuration(proxyBeanMethods = false)
@EnableConfigurationProperties(UndertowAccessLogProperties.class)
@ConditionalOnClass(name = "io.undertow.Undertow")
@ConditionalOnClass(name = {
"io.undertow.Undertow",
"io.undertow.server.handlers.accesslog.AccessLogHandler",
"io.undertow.server.handlers.accesslog.JBossLoggingAccessLogReceiver"
})
@ConditionalOnProperties( {
@ConditionalOnProperty(name = "server.undertow.accesslog.enabled", havingValue = "false"),
@ConditionalOnProperty(name = "camel.component.platform-http.server.undertow.accesslog.use-camel-logging", havingValue = "true"),
Expand Down
11 changes: 9 additions & 2 deletions ...java/org/apache/camel/spring/boot/actuate/accesslog/ManagementAccessLogConfiguration.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,11 @@ public class ManagementAccessLogConfiguration {
* Undertow-specific configuration.
*/
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(name = "io.undertow.Undertow")
@ConditionalOnClass(name = {
"io.undertow.Undertow",
"io.undertow.server.handlers.accesslog.AccessLogHandler",
"io.undertow.server.handlers.accesslog.JBossLoggingAccessLogReceiver"
})
static class UndertowAccessLogCustomizerConfiguration {

// TODO reintroduce once spring-boot-starter-undertow will be available
Expand Down Expand Up @@ -78,7 +82,10 @@ static class UndertowAccessLogCustomizerConfiguration {
* Tomcat-specific configuration to disable access logging in the management context.
*/
@Configuration(proxyBeanMethods = false)
@ConditionalOnClass(name = "org.apache.catalina.startup.Tomcat")
@ConditionalOnClass(name = {
"org.apache.catalina.startup.Tomcat",
"org.apache.catalina.valves.AccessLogValve"
})
@ConditionalOnProperty(name = "management.server.accesslog.enabled", havingValue = "false")
static class TomcatAccessLogCustomizerConfiguration {

Expand Down
Loading