Skip to content

CAMEL-24000: camel-spring-boot - upgrade guide entry for Duration configuration properties#24593

Merged
Croway merged 1 commit into
apache:mainfrom
Croway:camel-24000-upgrade-guide
Jul 10, 2026
Merged

CAMEL-24000: camel-spring-boot - upgrade guide entry for Duration configuration properties#24593
Croway merged 1 commit into
apache:mainfrom
Croway:camel-24000-upgrade-guide

Conversation

@Croway

@Croway Croway commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Claude Code on behalf of Federico Mariani (@Croway)

Upgrade guide entry for CAMEL-24000: camel-spring-boot binds several route controller and startup condition properties as java.time.Duration in 4.22 (apache/camel-spring-boot#1843). Plain numeric values keep meaning milliseconds; the entry documents the getter/setter type change for programmatic readers and why camel.clustered.controller.initial-delay keeps its String type.

Requested during review of apache/camel-spring-boot#1843.

🤖 Generated with Claude Code

…figuration properties

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

🌟 Thank you for your contribution to the Apache Camel project! 🌟
🤖 CI automation will test this PR automatically.

🐫 Apache Camel Committers, please review the following items:

  • First-time contributors require MANUAL approval for the GitHub Actions to run
  • You can use the command /component-test (camel-)component-name1 (camel-)component-name2.. to request a test from the test bot although they are normally detected and executed by CI.
  • You can label PRs using skip-tests and test-dependents to fine-tune the checks executed by this PR.
  • Build and test logs are available in the summary page. Only Apache Camel committers have access to the summary.

⚠️ Be careful when sharing logs. Review their contents before sharing them publicly.

@github-actions github-actions Bot added the docs label Jul 10, 2026

@gnodet gnodet left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean, accurate upgrade guide entry documenting the java.time.Duration property type changes from camel-spring-boot PR #1843.

Verified:

  • All six properties correctly listed: four long fields in SupervisingRouteControllerConfiguration and two int fields in CamelStartupConditionConfigurationProperties
  • The claim about camel.clustered.controller.initial-delay keeping its String type is correct — ClusteredRouteControllerConfiguration was not modified for Duration conversion
  • Backward compatibility note is accurate — @DurationUnit(ChronoUnit.MILLIS) ensures plain numeric values are still interpreted as milliseconds
  • AsciiDoc formatting follows existing conventions (heading level, backtick-quoted class names, bullet lists)

This review was generated by an AI agent and may contain inaccuracies. Please verify all suggestions before applying.

Claude Code on behalf of Guillaume Nodet

gnodet added a commit to gnodet/camel that referenced this pull request Jul 10, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🧪 CI tested the following changed modules:

  • docs

🔬 Scalpel shadow comparison — Scalpel: 1 tested, 0 compile-only — current: 0 all tested

Maveniverse Scalpel detected 1 affected modules (current approach: 0).

⚠️ Modules only in Scalpel (1)
  • docs

Skip-tests mode would test 1 modules (1 direct + 0 downstream), skip tests for 0 (generated code, meta-modules)

Modules Scalpel would test (1)
  • docs

ℹ️ Shadow mode — Scalpel observes but does not affect test execution. Learn more


⚙️ View full build and test results

gnodet added a commit to gnodet/camel that referenced this pull request Jul 10, 2026
@Croway
Croway merged commit 9407db5 into apache:main Jul 10, 2026
6 checks passed
gnodet added a commit to gnodet/camel that referenced this pull request Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants