feat: implement IPolicyFilter in PolicyFilter#386
Merged
hsluoyz merged 2 commits intoapache:masterfrom Sep 24, 2025
Merged
Conversation
Member
|
@FAUST-BENCHOU plz review |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issue #385 by implementing the IPolicyFilter interface in the PolicyFilter class, enabling its use with filtered extension methods. The change ensures that the PolicyFilter class conforms to the expected interface contract for policy filtering operations.
- Made PolicyFilter implement IPolicyFilter interface
- Added comprehensive test coverage for filtered policy operations across all built-in adapter types
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Casbin/Persist/PolicyFilter.cs | Implements IPolicyFilter interface in PolicyFilter class |
| Casbin.UnitTests/PersistTests/AdapterTest.cs | Adds filtered policy tests for FileAdapter, StreamAdapter, and TextAdapter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
FAUST-BENCHOU
approved these changes
Sep 24, 2025
FAUST-BENCHOU
approved these changes
Sep 24, 2025
|
🎉 This PR is included in version 2.15.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #385, implementing the IPolicyFilter interface in the PolicyFilter class so that it may be used with the filtered extension methods.
This also adds a set of very basic policy filtered tests for each of the built-in adapter types.