Skip to content

feat: use destructuring syntax for structured logging in LoggerExtension #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsluoyz merged 2 commits into from
Oct 31, 2025
Merged

feat: use destructuring syntax for structured logging in LoggerExtension #391

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef1ce27
Initial plan
Copilot Oct 31, 2025
10b9e00
Fix structured logging to use destructuring syntax for RequestValues
Copilot Oct 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Casbin/Extensions/LoggerExtension.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,20 +11,20 @@ public static class LoggerExtension
public static void LogEnforceCachedResult<TRequest>(this ILogger logger, in TRequest requestValues, bool result)
where TRequest : IRequestValues
{
logger.LogInformation("Request: {1} ---> {0} (cached)", result, requestValues);
logger.LogInformation("Request: {@1} ---> {0} (cached)", result, requestValues);
}

public static void LogEnforceResult<TRequest>(this ILogger logger, in TRequest requestValues, bool result)
where TRequest : IRequestValues
{
logger.LogInformation("Request: {1} ---> {0}", result, requestValues);
logger.LogInformation("Request: {@1} ---> {0}", result, requestValues);
}

public static void LogEnforceResult<TRequest>(this ILogger logger, in TRequest requestValues,
bool result, IEnumerable<IEnumerable<string>> explains)
where TRequest : IRequestValues
{
logger.LogInformation("Request: {1} ---> {0}\nHit Store: {2}", result, requestValues,
logger.LogInformation("Request: {@1} ---> {0}\nHit Store: {2}", result, requestValues,
string.Join("\n", explains.Select(explain =>
string.Join(", ", explain))));
}
Expand Down
Loading