CASSANALYTICS-51 : Support for Tuples, Tuples with collections and UDTs in the Bulk writer#174
Open
skoppu22 wants to merge 6 commits intoapache:trunkfrom
Open
CASSANALYTICS-51 : Support for Tuples, Tuples with collections and UDTs in the Bulk writer#174skoppu22 wants to merge 6 commits intoapache:trunkfrom
skoppu22 wants to merge 6 commits intoapache:trunkfrom
Conversation
| { | ||
| String sanitizedName = sanitizeTypeName(type.cqlName()); | ||
|
|
||
| try |
Member
There was a problem hiding this comment.
NIT: utility method would save space on repeated try-catch blocks.
| * @param type the type to unwrap | ||
| * @return the inner type if frozen, otherwise the original type | ||
| */ | ||
| public static CqlField.CqlType unwrapFrozen(CqlField.CqlType type) |
Member
There was a problem hiding this comment.
NIT: unwrapIfFrozen sounds better.
lukasz-antoniak
requested changes
Mar 5, 2026
Member
lukasz-antoniak
left a comment
lukasz-antoniak
left a comment
There was a problem hiding this comment.
Thank you for a great patch. Two small NITs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for writing Tuples and Tuples with collections or UDTs (and possible combinations of these) in the Bulk writer.
CI pipeline:
https://app.circleci.com/pipelines/github/skoppu22/cassandra-analytics/53/workflows/03dd1ed4-6506-462b-9363-bafb27e9a4fb