Add minimal cardinality for service dependencies#840
Merged
pnoltes merged 13 commits intoapache:masterfrom Apr 16, 2026
Merged
Conversation
- Add service count to printinfo
pnoltes
requested changes
Apr 7, 2026
Contributor
pnoltes
left a comment
pnoltes
left a comment
There was a problem hiding this comment.
Overall LGTM, just got a remark about the functional test coverage
pnoltes
approved these changes
Apr 7, 2026
…lCardinality now determines whether a serviceDependency is required.
…bility in dm_service_dependency
PengZheng
requested changes
Apr 14, 2026
Contributor
PengZheng
left a comment
PengZheng
left a comment
There was a problem hiding this comment.
Nice improvement, thanks!
Overall LGTM. I just left some minor remarks.
PengZheng
reviewed
Apr 14, 2026
…ve memory layout of celix_dm_service_dependency_info_struct.
PengZheng
reviewed
Apr 15, 2026
PengZheng
reviewed
Apr 15, 2026
Co-authored-by: PengZheng <howtofly@gmail.com>
pnoltes
requested changes
Apr 15, 2026
Contributor
pnoltes
left a comment
pnoltes
left a comment
There was a problem hiding this comment.
Looks good, but one small nitpick: Please update the CHANGES.md for the backward incompatible update (removal setRequired).
…dinality' into feature/minimal_cardinality
pnoltes
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a minimal cardinality for service dependencies to determine when a service dependency is considered to be available. This gives the ability to wait for a component to start until a certain number of a service dependency are available.
Mentioned in https://docs.osgi.org/specification/osgi.cmpn/7.0.0/service.component.html#service.component-minimum.cardinality.property.
Update: