Remove Java and Timezone notices - when upgrading from 4.14+#219
Merged
Conversation
Contributor
Author
|
@blueorangutan docbuild |
|
@andrijapanicsb a Jenkins job has been kicked to build the document. I'll keep you posted as I make progress. |
|
Doc build preview: http://qa.cloudstack.cloud/docs/WIP-PROOFING/pr/219. (SL-JID 86) |
..as they are already in place in 4.14.
andrijapanicsb
changed the title
yadvr
approved these changes
Jun 7, 2021
Member
|
LGTM on the java include, but what about the timezone fix? Is that not required anymore? |
Contributor
Author
|
You are upgrading from 4.14 (4.14.1) or 4.15 - and the timezone in db.properties needs to be there to be able to run those (older) versions - i.e. it's already there. So no need to add it "again" - that's why both changes/removals I've proposed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the notice about Java 11 version and timezone in my.cnf or db.properties - as these already HAVE to be in place in order to even run the 4.15.0 (this is upgrade page FROM 4.15.0 to 4.15.1).
ping @rhtyd @DaanHoogland for review pls (need to do the same for upgrade FROM 4.14)