Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## main #12617 +/- ##
=============================================
- Coverage 17.90% 3.68% -14.23%
=============================================
Files 5938 454 -5484
Lines 532864 38798 -494066
Branches 65192 7151 -58041
=============================================
- Hits 95392 1428 -93964
+ Misses 426793 37183 -389610
+ Partials 10679 187 -10492
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
5fc1f12 to
9e03f4b
Compare
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16801 |
| UserVmVO vm = userVmDao.findById(vmId); | ||
| String cantHandleLog = String.format("Default VM snapshot cannot handle VM snapshot for [%s]", vm); | ||
|
|
||
| if (isRunningVMVolumeOnCLVMStorage(vm, cantHandleLog)) { |
There was a problem hiding this comment.
@Pearl1594
what's the image format on CLVM ? RAW or QCOW2 ?
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
a08e7a5 to
df61d6f
Compare
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
df61d6f to
43e9384
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #12617 +/- ##
============================================
+ Coverage 18.01% 18.45% +0.43%
- Complexity 16607 17433 +826
============================================
Files 6029 6048 +19
Lines 542154 553990 +11836
Branches 66451 70679 +4228
============================================
+ Hits 97681 102221 +4540
- Misses 433457 440446 +6989
- Partials 11016 11323 +307
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
3f900e8 to
c9dd7ed
Compare
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16875 |
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 16877 |
|
@blueorangutan test |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
| * @param volume The CLVM volume | ||
| * @return Host ID that has the exclusive lock, or null if cannot be determined | ||
| */ | ||
| private Long findVolumeLockHost(VolumeInfo volume) { |
There was a problem hiding this comment.
@Pearl1594 this method seems unused, please check.
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
|
[SF] Trillian test result (tid-15988)
|
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
382b67d to
1143aeb
Compare
…as first check point and then fanning out
Pearl1594
force-pushed
the
clvm-enhancements
branch
from
1143aeb to
53e9b18
Compare
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17742 |
|
@blueorangutan test |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@blueorangutan package |
|
@Pearl1594 a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17743 |
|
|
Hi @Pearl1594 , I'm a little confused. Is the image type for CLVM-NG QCOW2 or RAW? Or can the user choose the image format? I was reading the link from the proposal design, but I didn't find this information. |
|
@Luskan777 , CLVM_NG is qcow2, CLVM is RAW - there will be 2 storage pool type. I've updated the doc to reflect the same. Thanks. |
|
@blueorangutan test |
|
@Pearl1594 a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
Thank you for your reply @Pearl1594. Sorry for my ignorance @Pearl1594 , but why did you choose qcow2 and not RAW? Is it because of the snapshots? Or because it's thin-provisioning? And will it be possible to use RAW in CLVM-NG at some point? Does that make sense? I ask because RAW is superior to QCOW2, as it has less overhead, resulting in better performance (IOPS and latency). PS: If I'm missing anything that's in your documentation, please correct me 😬 |
|
@Luskan777 To use RAW volumes, you could use CLVM. CLVM_NG was introduced with QCOW2 support to leverage some benefits that qcow2 offers, like incremental snapshots. As of now, it is not thin provisioning. |
Description
This PR enhances the existing CLVM implementation which was based on the deprecated CLVM technology which was based on corosync/pacemaker. With RHEL 7 having reached EOL, CLVM seems to be broken. CLVM supports RAW volumes on LVM , where as CLVM_NG support QCOW2 on LVM.
Further details: https://cwiki.apache.org/confluence/display/CLOUDSTACK/Modernized+CLVM%3A+Enhancements+and+CLVM_NG+support
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?