server: copy template details to vm instance details when import VM by weizhouapache · Pull Request #12793 · apache/cloudstack

weizhouapache · 2026-03-11T15:22:37Z

Description

This PR fixes #12594

Tested

Unmanage a VM on KVM
Import it with the vm template with setting guest.cpu.mode=host-passthrough

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2026-03-11T15:23:14Z

@blueorangutan package

blueorangutan · 2026-03-11T15:24:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

Copilot

Pull request overview

This PR aims to fix VM import so that a template’s details are loaded and then copied into the imported VM’s instance details.

Changes:

Fetches the template VO from the DAO and explicitly loads its details prior to commitUserVm.
Switches downstream calls (checkIfDynamicScalingCanBeEnabled, commitUserVm, ISO format check) to use the DAO-loaded VMTemplateVO.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-03-11T15:32:01Z

Codecov Report

❌ Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 17.68%. Comparing base (c3d6a8c) to head (0ed525a).
⚠️ Report is 142 commits behind head on 4.22.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	85.71%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.22   #12793      +/-   ##
============================================
+ Coverage     17.61%   17.68%   +0.06%     
- Complexity    15661    15791     +130     
============================================
  Files          5917     5922       +5     
  Lines        531402   533125    +1723     
  Branches      64971    65203     +232     
============================================
+ Hits          93586    94259     +673     
- Misses       427262   428223     +961     
- Partials      10554    10643      +89

Flag	Coverage Δ
uitests	`3.69% <ø> (-0.01%)`	⬇️
unittests	`18.75% <85.71%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2026-03-11T16:38:27Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17101

weizhouapache · 2026-03-11T16:50:06Z

@blueorangutan test

blueorangutan · 2026-03-11T16:52:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-03-12T07:43:16Z

[SF] Trillian test result (tid-15611)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 50536 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr12793-t15611-kvm-ol8.zip
Smoke tests completed. 144 look OK, 5 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestListIdsParams>:teardown	`Error`	1.16	test_list_ids_parameter.py
test_01_primary_storage_nfs	`Error`	0.16	test_primary_storage.py
ContextSuite context=TestStorageTags>:setup	`Error`	0.26	test_primary_storage.py
test_01_primary_storage_scope_change	`Error`	0.11	test_primary_storage_scope.py
test_01_snapshot_root_disk	`Error`	5.84	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.63	test_snapshots.py
test_02_list_snapshots_with_removed_data_store	`Error`	46.63	test_snapshots.py
ContextSuite context=TestSnapshotStandaloneBackup>:teardown	`Error`	28.38	test_snapshots.py
test_01_snapshot_usage	`Error`	25.66	test_usage.py
test_01_vpn_usage	`Error`	1.11	test_usage.py

sureshanaparti

clgtm

sudo87

clgtm

github-actions · 2026-03-24T19:12:03Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

sureshanaparti · 2026-04-13T06:36:45Z

@weizhouapache can you resolve the conflicts.

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

+            // Ensure template details are loaded so that commitUserVm can copy them into the VM's details map
+            VMTemplateVO vmTemplateVO = _templateDao.findById(template.getId());
+            if (vmTemplateVO == null) {
+                throw new InvalidParameterValueException("Unable to find template with id " + template.getId() + " for virtual machine import");
+            }
+            _templateDao.loadDetails(vmTemplateVO);


+            final Boolean dynamicScalingEnabled = checkIfDynamicScalingCanBeEnabled(null, serviceOffering, vmTemplateVO, zone.getId());
+            return commitUserVm(true, zone, host, lastHost, vmTemplateVO, hostName, displayName, owner,
                    null, null, userData, null, null, isDisplayVm, keyboard,
                    accountId, userId, serviceOffering, template.getFormat().equals(ImageFormat.ISO), sshPublicKeys, networkNicMap,


server: copy template details to vm instance details when import VM

a00adaa

weizhouapache linked an issue Mar 11, 2026 that may be closed by this pull request

Template setting 'guest.cpu.mode' is not set on instances imported from QCOW2 #12594

Open

weizhouapache added this to the 4.22.1 milestone Mar 11, 2026

weizhouapache added status:needs-testing status:needs-review labels Mar 11, 2026

weizhouapache requested a review from Copilot March 11, 2026 15:24

Copilot AI reviewed Mar 11, 2026

View reviewed changes

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java

Comment thread server/src/main/java/com/cloud/vm/UserVmManagerImpl.java Outdated

Copilot started reviewing on behalf of weizhouapache March 11, 2026 15:44 View session

sureshanaparti added this to Apache CloudStack 4.22.1 Mar 12, 2026

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.1 Mar 12, 2026

sureshanaparti approved these changes Mar 12, 2026

View reviewed changes

weizhouapache marked this pull request as ready for review March 12, 2026 10:37

sudo87 approved these changes Mar 12, 2026

View reviewed changes

sureshanaparti removed the status:needs-review label Mar 12, 2026

github-actions Bot added the status:has-conflicts label Mar 24, 2026

sureshanaparti added the status:waiting-for-author label Apr 13, 2026

sureshanaparti removed this from Apache CloudStack 4.22.1 Apr 24, 2026

sureshanaparti modified the milestones: 4.22.1, 4.22.2 Apr 24, 2026

weizhouapache requested a review from Copilot May 11, 2026 09:42

apply suggestions

0ed525a

weizhouapache force-pushed the 4.22-import-vm-copy-template-details branch from 7dc8127 to 0ed525a Compare May 11, 2026 09:43

Copilot AI reviewed May 11, 2026

View reviewed changes

github-actions Bot removed the status:has-conflicts label May 11, 2026

Copilot started reviewing on behalf of weizhouapache May 11, 2026 10:27 View session

Conversation

weizhouapache commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

weizhouapache commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 11, 2026

Uh oh!

blueorangutan commented Mar 12, 2026

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sudo87 left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Mar 24, 2026

Uh oh!

sureshanaparti commented Apr 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

weizhouapache commented Mar 11, 2026 •

edited

Loading

codecov Bot commented Mar 11, 2026 •

edited

Loading