CloudStack Volume support with ONTAP storage by rajiv-jain-netapp · Pull Request #13053 · apache/cloudstack

rajiv-jain-netapp · 2026-04-22T02:58:39Z

Description

Co-authored-by: Sandeep Locharla sandeep.locharla@netapp.com
Co-authored-by: Piyush Srivastava piyush5@netapp.com
Co-authored-by: Surya Gupta suryag@netapp.com

This PR...

Supports cloudstack-volume usecases support for NFS3 and iSCSI protocols.
Support for cloudStack-volume create/delete/attach/detach/snapshot-create.
Instance create/delete/snapshot-create support
Snapshot-create would not support
1. memory snapshot
2. user input for quicing option during snapshot creation

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Testing Done:

VM create

Validate the respective CloudStack volume

Storage view for the cloudStack volumes

VM snapshot support

Storage view, post snapshot create

CloudStack UI list view for snapshot

CloudStack volume snapshot support

Storage view, post snapshot create

CloudStack UI list view for snapshot

How did you try to break this feature and the system with this change?

… added EOF fixes

… added EOF fixes + correcting license header

Initial primary storage pool plugin skeleton

…POJOs" This reverts commit fe0f752.

…POJOs" This reverts commit 28faca1.

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28

* CSTACKEX-29 Cluster, SVM and Aggr Feign Client * CSTACKEX-29 Change the endpoint method name in feign client * CSTACKEX-29 Make the alignment proper * CSTACKEX-29 Added License Info * CSTACKEX-29 Resolve Review Comments * CSTACKEX-29 Remove Component Annotation from datastoredriverclass * CSTACKEX-29 Resolve Style check issues * CSTACKEX-29 Resolve ALL Style issues * CSTACKEX-29 Resolve Precommits Issues * CSTACKEX-29 Added Method comments and change the ontap response class name --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-31 NAS and Job Feign Client and POJOs * CSTACKEX-31 Fixed Checks Issues * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Resolve Review Comments * CSTACKEX-31 Added Aggr and size to volume model * CSTACKEX-31 Change the export policy endpoint path * CSTACKEX-31 Fixed check styles --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-7: ONTAP Primary storage pool --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

CSTACKEX-34: Upgrade to framework classes design

* CSTACKEX-35 Create Async * CSTACKEX-35 Added Null and empty check * CSTACKEX-35 Resolved review comments * CSTACKEX-35 Removed Type Casting for logger --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

* CSTACKEX-1: Feign changes and fixes for getting storage pool creation to work * CSTACKEX-01: Create Primary Storage pool changes with working code * CSTACKEX-01: Addressed all review comments and updated some code * CSTACKEX-01: Made some changes to fix some errors seen during testing * CSTACKEX-01: Addressed additional comments --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

Copilot

Pull request overview

This PR adds NetApp ONTAP as a managed primary storage provider, including UI wiring for pool creation and backend support for CloudStack volume workflows over NFS3 and iSCSI, plus VM/volume snapshot integration for KVM.

Changes:

UI: adds NetApp ONTAP provider inputs (IP/username/password/SVM/protocol) and provider-specific parameter mapping.
Backend: introduces ONTAP storage strategies (NAS/SAN), lifecycle attach/delete behavior, and Feign clients/models for snapshot + file/LUN restore workflows.
KVM/engine: adjusts iSCSI handling and VM snapshot behavior to integrate ONTAP-specific snapshot strategy/limitations.

Reviewed changes

Copilot reviewed 42 out of 42 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
ui/src/views/infra/zone/ZoneWizardLaunchZone.vue	Adds NetApp ONTAP provider handling + details mapping during zone wizard primary storage creation
ui/src/views/infra/zone/ZoneWizardAddResources.vue	Adds ONTAP-specific form fields and protocol choices in zone wizard
ui/src/views/infra/zone/StaticInputsForm.vue	Adds numeric-format validation helper used by static forms
ui/src/views/infra/AddPrimaryStorage.vue	Adds ONTAP provider form fields, validation rules, and API param mapping
ui/public/locales/en.json	Adds English i18n strings for ONTAP fields/tooltips
server/src/main/java/com/cloud/vm/snapshot/VMSnapshotManagerImpl.java	Adds ONTAP-specific error message when memory snapshots requested without a suitable strategy
plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/service/UnifiedNASStrategyTest.java	Adds unit tests for UnifiedNASStrategy behaviors
plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/service/StorageStrategyTest.java	Adds unit tests for StorageStrategy connect/volume/network methods
plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycleTest.java	Extends lifecycle tests for init/attach cluster/zone flows
plugins/storage/volume/ontap/src/test/java/org/apache/cloudstack/storage/driver/OntapPrimaryDatastoreDriverTest.java	Adds driver tests for create/delete/grant/revoke access flows
plugins/storage/volume/ontap/src/main/resources/META-INF/cloudstack/storage-volume-ontap/spring-storage-volume-ontap-context.xml	Registers ONTAP VM snapshot strategy bean
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageUtils.java	Adds ONTAP helpers for auth headers, naming, and protocol-specific volume request building
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/utils/OntapStorageConstants.java	Updates provider naming and adds constants for snapshot/mount options
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/model/CloudStackVolume.java	Extends request/response model to support snapshot workflows (flexvol UUID, destination path)
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/model/AccessGroup.java	Refactors access-group request to use storagePoolId instead of PrimaryDataStoreInfo
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedSANStrategy.java	Implements iSCSI LUN CRUD, igroup management, LUN mapping helpers, and snapshot revert via CLI API
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/UnifiedNASStrategy.java	Implements NFS volume handling via host commands + export policy management + snapshot revert via CLI API
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/StorageStrategy.java	Centralizes Feign client creation and adds snapshot job polling + snapshot feign accessors
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/service/SANStrategy.java	Adds SAN helper contract for ensuring LUN mappings and initiator validation
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/provider/StorageProviderFactory.java	Selects unified NAS/SAN strategy by protocol and injects components
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/listener/OntapHostListener.java	Passes pool details to agent on host connect and updates pool host refs/capacity
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/lifecycle/OntapPrimaryDatastoreLifecycle.java	Refactors initialization inputs, forces NFSv3 mount options, and adds attach/delete logic updates
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/VolumeConcise.java	Adds concise Volume model used by snapshot responses
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/SnapshotFileRestoreRequest.java	Adds request model for snapshot file restore API
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/OntapStorage.java	Refactors ONTAP connection model to use storageIP and removes disaggregated flag
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/LunRestoreRequest.java	Adds request model for LUN restore API
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/FlexVolSnapshot.java	Adds model for FlexVolume-level snapshots
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/FileInfo.java	Adjusts file model fields for NAS operations
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/FileClone.java	Adds request model for ONTAP file clone
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/model/CliSnapshotRestoreRequest.java	Adds CLI passthrough restore-file request model
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SnapshotFeignClient.java	Adds Feign client for FlexVol snapshot and restore APIs (including CLI passthrough)
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/SANFeignClient.java	Adds Feign method for LUN restore
plugins/storage/volume/ontap/src/main/java/org/apache/cloudstack/storage/feign/client/NASFeignClient.java	Updates file GET to include metadata and adds file clone endpoint
plugins/storage/volume/ontap/pom.xml	Adds dependencies and surefire argLine for tests
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java	Makes iSCSI login/create idempotent, rescans sessions, avoids logging out when other LUNs exist, adds flush/sync
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtCreateDiskOnlyVMSnapshotCommandWrapper.java	Improves error handling and consolidates cleanup logic for snapshot deltas
engine/storage/volume/src/main/java/org/apache/cloudstack/storage/volume/VolumeServiceImpl.java	Updates managed template copy flow to use iSCSI/LUN info available post-grantAccess for ONTAP
engine/storage/snapshot/src/main/java/org/apache/cloudstack/storage/vmsnapshot/KvmFileBasedStorageVmSnapshotStrategy.java	Excludes ONTAP managed pools from the generic KVM file-based VM snapshot strategy and improves failure messages

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-04-22T08:15:07Z

Codecov Report

❌ Patch coverage is 0% with 1627 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.02%. Comparing base (ed575cc) to head (10cb764).
⚠️ Report is 110 commits behind head on main.

Files with missing lines	Patch %	Lines
...ck/storage/driver/OntapPrimaryDatastoreDriver.java	0.00%	421 Missing ⚠️
...ck/storage/vmsnapshot/OntapVMSnapshotStrategy.java	0.00%	395 Missing ⚠️
...cloudstack/storage/service/UnifiedSANStrategy.java	0.00%	261 Missing ⚠️
...cloudstack/storage/service/UnifiedNASStrategy.java	0.00%	179 Missing ⚠️
...hypervisor/kvm/storage/IscsiAdmStorageAdaptor.java	0.00%	91 Missing ⚠️
...rage/lifecycle/OntapPrimaryDatastoreLifecycle.java	0.00%	53 Missing ⚠️
...he/cloudstack/storage/utils/OntapStorageUtils.java	0.00%	44 Missing ⚠️
...udstack/storage/feign/model/LunRestoreRequest.java	0.00%	28 Missing ⚠️
...loudstack/storage/feign/model/FlexVolSnapshot.java	0.00%	25 Missing ⚠️
...LibvirtCreateDiskOnlyVMSnapshotCommandWrapper.java	0.00%	24 Missing ⚠️
... and 13 more

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #13053      +/-   ##
============================================
+ Coverage     17.95%   18.02%   +0.07%     
- Complexity    16503    16674     +171     
============================================
  Files          6019     6043      +24     
  Lines        540748   542990    +2242     
  Branches      66255    66612     +357     
============================================
+ Hits          97084    97877     +793     
- Misses       432723   434115    +1392     
- Partials      10941    10998      +57

Flag	Coverage Δ
uitests	`3.52% <ø> (-0.02%)`	⬇️
unittests	`19.18% <0.00%> (+0.07%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

#46)

rajiv-jain-netapp · 2026-04-27T02:48:41Z

@DaanHoogland @winterhazel , How can we re-trigger the build?

winterhazel · 2026-04-27T02:57:34Z

@DaanHoogland @winterhazel , How can we re-trigger the build?

@rajiv-jain-netapp you can ping @blueorangutan and use the package command, like this:

@blueorangutan package

blueorangutan · 2026-04-27T02:58:04Z

@winterhazel a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2026-04-27T03:55:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 17610

DaanHoogland · 2026-04-28T14:32:34Z

@blueorangutan test

blueorangutan · 2026-04-28T14:34:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2026-04-28T14:36:24Z

[SF] Trillian Build Failed (tid-15969)

blueorangutan · 2026-04-29T23:08:06Z

[SF] Trillian test result (tid-15974)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56045 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr13053-t15974-kvm-ol8.zip
Smoke tests completed. 151 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2026-04-30T09:03:57Z

@weizhouapache @winterhazel , at your discretion (ready for merge for my part)

winterhazel

Currently reviewing. This will take some time, so I am submitting the reviews partially.

winterhazel · 2026-05-01T15:39:14Z


    private static final List<Storage.StoragePoolType> supportedStoragePoolTypes = List.of(Storage.StoragePoolType.Filesystem, Storage.StoragePoolType.NetworkFilesystem, Storage.StoragePoolType.SharedMountPoint);

+    private static final String ONTAP_PROVIDER_NAME = "NetApp ONTAP";


This constant is declared in 3 places. Perhaps we could create a file in a single common dependency (maybe cloud-api) to declare the plugin names?

winterhazel · 2026-05-01T15:46:32Z

            grantAccess(volumeInfo, destHost, primaryDataStore);
+            volumeInfo = volFactory.getVolume(volumeInfo.getId(), primaryDataStore);
+            // For Netapp ONTAP iscsiName or Lun path  is available only after grantAccess
+            String managedStoreTarget = volumeInfo.get_iScsiName() != null ? volumeInfo.get_iScsiName() : volumeInfo.getUuid();


Suggested change

String managedStoreTarget = volumeInfo.get_iScsiName() != null ? volumeInfo.get_iScsiName() : volumeInfo.getUuid();

String managedStoreTarget = ObjectUtils.defaultIfNull(volumeInfo.get_iScsiName(), volumeInfo.getUuid());

@winterhazel what is the comment on this statement?

This is replacing the ternary on line 1345 with a call to ObjectUtils.defaultIfNull. They essentially do the same thing, but we tend to use the latter for legibility and avoiding two calls to the nullable value (volumeInfo.get_iScsiName())

winterhazel · 2026-05-01T16:07:33Z

+            primaryDataStore.setDetails(details);
+            // Update destTemplateInfo with the iSCSI path from volumeInfo
+            if (destTemplateInfo instanceof TemplateObject) {
+                ((TemplateObject)destTemplateInfo).setInstallPath(volumeInfo.getPath());


This setInstallPath here may affect other primary storage solutions. Is it possible to place it inside a method of the ONTAP plugin's driver, or only execute it if ONTAP is being used?

winterhazel · 2026-05-01T16:14:27Z

+    @JsonProperty("uuid")
+    private String uuid;
+    @JsonProperty("name")
+    private String name;
+    public String getUuid() {
+        return uuid;
+    }
+    public void setUuid(String uuid) {
+        this.uuid = uuid;
+    }
+    public String getName() {
+        return name;
+    }
+    public void setName(String name) { this.name = name;  }


Suggested change

@JsonProperty("uuid")

private String uuid;

@JsonProperty("name")

private String name;

public String getUuid() {

return uuid;

}

public void setUuid(String uuid) {

this.uuid = uuid;

}

public String getName() {

return name;

}

public void setName(String name) { this.name = name; }

@JsonProperty("uuid")

private String uuid;

@JsonProperty("name")

private String name;

public String getUuid() {

return uuid;

}

public void setUuid(String uuid) {

this.uuid = uuid;

}

public String getName() {

return name;

}

public void setName(String name) {

this.name = name;

}

@winterhazel, I did not get your comment even here?

It is a formatting suggestion. Leaving a blank line between method/attribute declarations, and not declaring methods in a single line.

winterhazel · 2026-05-01T16:15:11Z

    }
+    public String getFlexVolumeUuid() {
+        return flexVolumeUuid;
+    }


Suggested change

}

}

@winterhazel what is the recommended change/comment?

Having a blank line before/after the declaration of method getFlexVolumeUuid.

winterhazel · 2026-05-01T16:15:25Z

+    public String getDestinationPath() { return this.destinationPath; }
+    public void setDestinationPath(String destinationPath) { this.destinationPath = destinationPath; }


Adjust the formatting

In our previous PR, we had been told to maintain the single-line method implementation as above.

I think there are no rules for this specific case in our coding conventions, but we tend to declare all methods in multiple lines instead of a single one.

I never heard such a recommendation before @rajiv-jain-netapp . It is not usual.

Sure I will update them

winterhazel · 2026-05-01T16:17:39Z

+        // Inject mocks into the inherited fields via reflection
+        // DefaultVMSnapshotStrategy fields
+        setField(strategy, DefaultVMSnapshotStrategy.class, "vmSnapshotHelper", vmSnapshotHelper);
+        setField(strategy, DefaultVMSnapshotStrategy.class, "guestOSDao", guestOSDao);
+        setField(strategy, DefaultVMSnapshotStrategy.class, "userVmDao", userVmDao);
+        setField(strategy, DefaultVMSnapshotStrategy.class, "vmSnapshotDao", vmSnapshotDao);
+        setField(strategy, DefaultVMSnapshotStrategy.class, "agentMgr", agentMgr);
+        setField(strategy, DefaultVMSnapshotStrategy.class, "volumeDao", volumeDao);
+
+        // StorageVMSnapshotStrategy fields
+        setField(strategy, StorageVMSnapshotStrategy.class, "storagePool", storagePool);
+        setField(strategy, StorageVMSnapshotStrategy.class, "vmSnapshotDetailsDao", vmSnapshotDetailsDao);
+        setField(strategy, StorageVMSnapshotStrategy.class, "volumeDataFactory", volumeDataFactory);
+
+        // OntapVMSnapshotStrategy fields
+        setField(strategy, OntapVMSnapshotStrategy.class, "storagePoolDetailsDao", storagePoolDetailsDao);
+        setField(strategy, OntapVMSnapshotStrategy.class, "volumeDetailsDao", volumeDetailsDao);


Please use @InjectMocks instead of reflection

winterhazel · 2026-05-04T12:45:58Z

+        } catch (Exception e) {
+            logger.error("Unexpected exception while creating disk-only VM snapshot for VM [{}]. Deleting leftover deltas.", vmName, e);
+            cleanupLeftoverDeltas(volumeObjectTos, mapVolumeToSnapshotSizeAndNewVolumePath, storagePoolMgr);
+            return new CreateDiskOnlyVmSnapshotAnswer(cmd, false,
+                    String.format("Creation of disk-only VM snapshot for VM [%s] failed due to %s.", vmName, e.getMessage()), null);


Can this be unified with the catch block above?

winterhazel · 2026-05-04T13:31:16Z

@@ -158,8 +183,23 @@ public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool, Map<S
        return true;
    }


This result check block could be extracted into a single method to reduce indentation and make unit testing easier

winterhazel · 2026-05-04T13:31:52Z

@@ -123,21 +130,39 @@ public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool, Map<S
            }
        }


This result check block could be extracted into a single method to reduce indentation and make unit testing easier

winterhazel · 2026-05-04T13:38:56Z

+     */
+    private boolean hasOtherActiveLuns(String host, int port, String iqn, String lun) {
+        String prefix = "ip-" + host + ":" + port + "-iscsi-" + iqn + "-lun-";
+        java.io.File byPathDir = new java.io.File("/dev/disk/by-path");


Please import the File class and use only the classname

winterhazel · 2026-05-04T13:42:14Z

+                logger.info("Other LUNs still active after removing /" + iqn + "/" + lun + " — session kept alive.");
+                return true;


As the disconnect operation failed, I wonder if it makes more sense to throw an exception here instead

winterhazel · 2026-05-04T13:53:33Z

            logger.error("Failed to add host by HostListener as host was not found with id : {}", host.getId());
            return false;
        }
+        // TODO add storage pool get validation


Is this going to be addressed in this PR?

winterhazel · 2026-05-04T13:55:01Z

            return false;
        }

+        // TODO add host type check also since we support only KVM for now, host.getHypervisorType().equals(HypervisorType.KVM)


Is this going to be addressed in this PR?

winterhazel · 2026-05-04T13:56:43Z

-                throw new CloudRuntimeException("Unsupported configuration: Disaggregated ONTAP is not supported.");
+                UnifiedNASStrategy unifiedNASStrategy = new UnifiedNASStrategy(ontapStorage);
+                ComponentContext.inject(unifiedNASStrategy);
+                unifiedNASStrategy.setOntapStorage(ontapStorage);


Is this set needed? ontapStorage is already passed as a parameter to unifiedNASStrategy

winterhazel · 2026-05-04T13:56:52Z

-                throw new CloudRuntimeException("Unsupported configuration: Disaggregated ONTAP is not supported.");
+                UnifiedSANStrategy unifiedSANStrategy = new UnifiedSANStrategy(ontapStorage);
+                ComponentContext.inject(unifiedSANStrategy);
+                unifiedSANStrategy.setOntapStorage(ontapStorage);


Is this set needed? ontapStorage is already passed as a parameter to unifiedSANStrategy

Jain, Rajiv and others added 30 commits October 3, 2025 14:02

Initial primary storage pool plugin skeleton

4c8c8d9

Initial primary storage pool plugin skeleton - added license string

bf838b3

Initial primary storage pool plugin skeleton - added license string +…

b82fb40

… added EOF fixes

Initial primary storage pool plugin skeleton - added license string +…

1199d55

… added EOF fixes + correcting license header

Merge pull request #1 from NetApp/feature-CSTACKEX-24

ebc3f00

Initial primary storage pool plugin skeleton

Feignconfiguration and volume feignClient along with desired POJOs

28faca1

Feignconfiguration and volume feignClient along with desired POJOs

fe0f752

Revert "Feignconfiguration and volume feignClient along with desired …

35f1011

…POJOs" This reverts commit fe0f752.

Revert "Feignconfiguration and volume feignClient along with desired …

a03a2c4

…POJOs" This reverts commit 28faca1.

Feignconfiguration and volume feignClient along with desired POJOs

2e0efe8

Feignconfiguration and volume feignClient along with desired POJOs

a96eb9e

CSTACKEX-28: added copyright comment in the logger configuration

0f09c5f

CSTACKEX-28: added newline in the end of the file

2cc4b0c

CSTACKEX-28 - incorporated review comments

033c23d

Merge pull request #4 from NetApp/feature/CSTACKEX-28

2822946

Feignconfiguration and volume feignClient along with desired POJOs with cstack 28

CSTACKEX-30 SAN Feign Client (#8)

a492797

* CSTACKEX-30 SAN Feign Client * CSTACKEX-30 Fixed check style issues * CSTACKEX-30 Fixed review comments --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

CSTACKEX-7: ONTAP Primary storage pool (#9)

25353c2

* CSTACKEX-7: ONTAP Primary storage pool --------- Co-authored-by: Locharla, Sandeep <Sandeep.Locharla@netapp.com>

CSTACKEX-34: Upgrade to framework classes design

973f5e2

CSTACKEX-34: incorporating the review comments

686a892

CSTACKEX-34: transient changes to the review comments

edfcdde

CSTACKEX-34: Unable to get checkstyle pass hence fixing this as well

73eb9f5

CSTACKEX-34: further review comments incorporations

465fffe

CSTACKEX-34: addressing checkstyle issues

3d6bd91

CSTACKEX-34: fix checksyle issues

5815ebd

Merge pull request #13 from NetApp/feature/CSTACKEX-34

618f957

CSTACKEX-34: Upgrade to framework classes design

CSTACKEX-35 Create Async (#14)

6c4b24e

* CSTACKEX-35 Create Async * CSTACKEX-35 Added Null and empty check * CSTACKEX-35 Resolved review comments * CSTACKEX-35 Removed Type Casting for logger --------- Co-authored-by: Gupta, Surya <Surya.Gupta@netapp.com>

Merge branch 'apache:main' into main

54ddfa9

boring-cyborg Bot added component:iscsi component:kvm component:primary-storage component:storage component:UI labels Apr 22, 2026

DaanHoogland requested review from Copilot, weizhouapache and winterhazel April 22, 2026 08:07

Copilot started reviewing on behalf of DaanHoogland April 22, 2026 08:07 View session

Copilot AI reviewed Apr 22, 2026

View reviewed changes

winterhazel added this to the 4.23.0 milestone Apr 22, 2026

rajiv-jain-netapp and others added 4 commits April 24, 2026 10:51

copilot review comments incorporation

9748198

bugfix/CSTACKEX-154: NPE check in delete datastore (#52)

cddacd1

bugfix/CSTACKEX-147: Deletion of non last VM on any host still shows … (

34e910c

#46)

Correction in code owners username

c86d377

boring-cyborg Bot added the component:integration label Apr 24, 2026

winterhazel added the status:needs-review label Apr 30, 2026

winterhazel reviewed May 1, 2026

View reviewed changes

winterhazel reviewed May 4, 2026

View reviewed changes

rajiv-jain-netapp force-pushed the sync/apache-main-apr-2026 branch from 10cb764 to c86d377 Compare May 5, 2026 11:46


		private static final List<Storage.StoragePoolType> supportedStoragePoolTypes = List.of(Storage.StoragePoolType.Filesystem, Storage.StoragePoolType.NetworkFilesystem, Storage.StoragePoolType.SharedMountPoint);

		private static final String ONTAP_PROVIDER_NAME = "NetApp ONTAP";

	String managedStoreTarget = volumeInfo.get_iScsiName() != null ? volumeInfo.get_iScsiName() : volumeInfo.getUuid();
	String managedStoreTarget = ObjectUtils.defaultIfNull(volumeInfo.get_iScsiName(), volumeInfo.getUuid());

		public String getDestinationPath() { return this.destinationPath; }
		public void setDestinationPath(String destinationPath) { this.destinationPath = destinationPath; }

		@@ -158,8 +183,23 @@ public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool, Map<S
		return true;
		}

		@@ -123,21 +130,39 @@ public boolean connectPhysicalDisk(String volumeUuid, KVMStoragePool pool, Map<S
		}
		}

		logger.info("Other LUNs still active after removing /" + iqn + "/" + lun + " — session kept alive.");
		return true;

Conversation

rajiv-jain-netapp commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

rajiv-jain-netapp commented Apr 27, 2026

Uh oh!

winterhazel commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Apr 27, 2026

Uh oh!

blueorangutan commented Apr 27, 2026

Uh oh!

DaanHoogland commented Apr 28, 2026

Uh oh!

blueorangutan commented Apr 28, 2026

Uh oh!

blueorangutan commented Apr 28, 2026

Uh oh!

blueorangutan commented Apr 29, 2026

Uh oh!

DaanHoogland commented Apr 30, 2026

Uh oh!

winterhazel left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rajiv-jain-netapp commented Apr 22, 2026 •

edited

Loading

codecov Bot commented Apr 22, 2026 •

edited

Loading

winterhazel commented Apr 27, 2026 •

edited

Loading

winterhazel May 1, 2026 •

edited

Loading

winterhazel May 4, 2026 •

edited

Loading

winterhazel May 4, 2026 •

edited

Loading

winterhazel May 4, 2026 •

edited

Loading