Skip to content

go dam#13094

Open
antonychigz-boop wants to merge 5 commits intoapache:mainfrom
antonychigz-boop:main
Open

go dam#13094
antonychigz-boop wants to merge 5 commits intoapache:mainfrom
antonychigz-boop:main

Conversation

@antonychigz-boop
Copy link
Copy Markdown

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a lot of changes in here that revert localisations of strings to english. Translations by speaker of any language are much appreciated @antonychigz-boop , but please remove any changes for languages you are not native or at least proficient in. I realise I am making an assumption here, but reverting to english is giving me that thought.
sorry to sound so negative, your work is appreciated.

Copy link
Copy Markdown
Author

@antonychigz-boop antonychigz-boop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ta

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like some internal work, not fit for community

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 3, 2026

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

Comment on lines -2 to -18
"alert.service.domainrouter": "Roteador do dom\u00ednio",
"error.dedicate.cluster.failed": "Falha ao dedicar cluster",
"error.dedicate.host.failed": "Falha ao dedicar host",
"error.dedicate.pod.failed": "Falha ao dedicar pod",
"error.dedicate.zone.failed": "Falha ao dedicar zona",
"error.execute.api.failed": "Falha ao executar API",
"error.fetching.async.job.result": "Foi encontrado um erro ao buscar o resultado do job ass\u00edncrono",
"error.form.message": "H\u00e1 problemas no formul\u00e1rio. Por favor, corrija-os.",
"error.password.not.match": "Os campos de senha n\u00e3o coincidem",
"error.release.dedicate.cluster": "Falha ao liberar cluster dedicado.",
"error.release.dedicate.host": "Falha ao liberar host dedicado.",
"error.release.dedicate.pod": "Falha ao liberar pod dedicado.",
"error.release.dedicate.zone": "Falha ao liberar zona dedicada.",
"error.unable.to.proceed": "N\u00e3o foi poss\u00edvel proceder. Por favor, contate um administrador.",
"firewall.close": "Firewall",
"icmp.code.desc": "Informe -1 para permitir todos os c\u00f3digos ICMP.",
"icmp.type.desc": "Informe -1 para permitir todos os tipos ICMP.",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will probably break the UI labels. We should always seek to use escaped unicode characters

Comment on lines -31 to -37
<pre>{{ $t('message.installwizard.cloudstack.helptext.website') }}<a href="https://cloudstack.apache.org" target="_blank">https://cloudstack.apache.org</a></pre>
<pre>{{ $t('message.installwizard.cloudstack.helptext.document') }}<a :href="'https://docs.cloudstack.apache.org/en/' + cloudstackminorversion" target="_blank">https://docs.cloudstack.apache.org/en/{{ cloudstackminorversion }}</a></pre>
<pre>{{ $t('message.installwizard.cloudstack.helptext.releasenotes') }}<a :href="'https://docs.cloudstack.apache.org/en/' + cloudstackminorversion + '/releasenotes/'" target="_blank">https://docs.cloudstack.apache.org/en/{{ cloudstackminorversion }}/releasenotes/</a></pre>

<pre>{{ $t('message.installwizard.cloudstack.helptext.mailinglists') }}<a href="https://cloudstack.apache.org/mailing-lists.html" target="_blank">https://cloudstack.apache.org/mailing-lists.html</a></pre>
<pre>{{ $t('message.installwizard.cloudstack.helptext.survey') }}<a href="https://cloudstack.apache.org/survey.html" target="_blank">https://cloudstack.apache.org/survey.html</a></pre>
<pre>{{ $t('message.installwizard.cloudstack.helptext.issues') }}<a href="https://github.com/apache/cloudstack/issues/new" target="_blank">https://github.com/apache/cloudstack/issues/new</a></pre>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should keep the community/documentation links as they currently are here.

Comment thread CHANGES.md
Comment on lines +7 to +11
NexaCloud Rebranding
-------------------

- CloudStack rebranded to NexaCloud; monochrome theme; communication links removed.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonychigz-boop, these changes seem to be targeted to an ACS fork; they are not suitable for the community repo

Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants