reset ssh key pair visibility by ernjvr · Pull Request #2778 · apache/cloudstack

ernjvr · 2018-07-27T13:52:16Z

Description

In the UI, on the Instances screen, the Quickview popup window and the Details window do not display the 'Reset SSH Key Pair' button for VMs in a running state. They only display when the VM is in a stopped state. This is inconsistent with the 'Reset Password' button behaviour, where it displays in both VM states: running and stopped. This fixes the issue so that the 'Reset SSH Key Pair' button also displays in both VM states.

Expected Behaviour:
In the UI, on the Instances screen, the Quickview popup window and the Details window must display the 'Reset SSH Key Pair' button in both VM states: running and stopped. When a user clicks on the 'Reset SSH Key Pair' button and a VM is in a running state, it will display a message "Vm xxx should be stopped to do SSH Key reset".
Actual Behaviour:
In the UI, on the Instances screen, the Quickview popup window and the Details window do not display the 'Reset SSH Key Pair' button for VMs in a running state. It only displays when the VM is in a stopped state.
Steps to reproduce:

Quickview popup window:
In the Cloudstack UI, in the left pane, click on the Instances tab. Choose a VM that is in a running state and hover the mouse over the Quickview link so that the Quickview popup window is displayed. The 'Reset SSH Key Pair' button does not display among the other allowed actions.
Details window:
In the Cloudstack UI, in the left pane, click on the Instances tab. Choose a VM that is in a running state and click the mouse on the VM name to display the Details window. The 'Reset SSH Key Pair' button does not display among the other allowed actions.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Manually (see screenshots above):

Quickview popup window:
In the Cloudstack UI, in the left pane, click on Instances tab. Choose a VM that is in a running state and hover the mouse over the Quickview link so that the Quickview popup window is displayed. The 'Reset SSH Key Pair' button now displays among the other allowed actions. After clicking on the button, it displays a message "Vm xxx should be stopped to do SSH Key reset".
Details window:
In the Cloudstack UI, in the left pane, click on Instances tab. Choose a VM that is in a running state and click the mouse on the VM name to display the Details window. The 'Reset SSH Key Pair' button does now display among the other allowed actions. After clicking on the button, it displays a message "Vm xxx should be stopped to do SSH Key reset".

Checklist:

I have read the CONTRIBUTING document.
My code follows the code style of this project.
My change requires a change to the documentation.
I have updated the documentation accordingly.
Testing
I have added tests to cover my changes.
All relevant new and existing integration tests have passed.
A full integration testsuite with all test that can run on my environment has passed.

… state

rafaelweingartner · 2018-07-27T14:01:02Z

We have two options here. We can add the button as this PR is doing. Or, we can remove the reset password button as well when the VM is not in stopped state.

I mean, should we show a button that the user cannot use?

ernjvr · 2018-07-27T14:38:33Z

Yes, the other option could also be feasible. Although, there is an argument that a lot of people figure out what they can do by looking at the buttons. Perhaps displaying a greyed-out disabled button would also be an option.

rafaelweingartner · 2018-07-27T14:49:28Z

Ah, yes that is true.

borisstoyanov · 2018-07-30T06:46:13Z

@blueorangutan package

blueorangutan · 2018-07-30T06:46:53Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-30T07:27:16Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2213

borisstoyanov · 2018-07-30T07:39:56Z

@blueorangutan test

blueorangutan · 2018-07-30T07:40:55Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

borisstoyanov · 2018-07-30T11:29:25Z

@blueorangutan package

blueorangutan · 2018-07-30T11:29:53Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-30T12:16:35Z

Packaging result: ✔centos6 ✖centos7 ✔debian. JID-2217

borisstoyanov · 2018-07-30T12:22:24Z

@blueorangutan package

blueorangutan · 2018-07-30T12:22:54Z

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

blueorangutan · 2018-07-30T12:53:58Z

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2219

borisstoyanov · 2018-07-30T12:55:18Z

@blueorangutan test

blueorangutan · 2018-07-30T12:55:53Z

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2018-07-30T17:39:18Z

Trillian test result (tid-2896)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34290 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2778-t2896-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermitten failure detected: /marvin/tests/smoke/test_vpc_router_nics.py
Intermitten failure detected: /marvin/tests/smoke/test_host_maintenance.py
Smoke tests completed. 62 look OK, 5 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1190.24	test_privategw_acl.py
test_04_nonsecured_to_secured_vm_migration	`Error`	239.94	test_vm_life_cycle.py
test_02_redundant_VPC_default_routes	`Failure`	254.78	test_vpc_redundant.py
test_03_create_redundant_VPC_1tier_2VMs_2IPs_2PF_ACL_reboot_routers	`Failure`	342.37	test_vpc_redundant.py
test_02_VPC_default_routes	`Failure`	186.57	test_vpc_router_nics.py

blueorangutan · 2018-07-30T22:22:51Z

Trillian test result (tid-2900)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32449 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2778-t2900-kvm-centos7.zip
Intermitten failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermitten failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermitten failure detected: /marvin/tests/smoke/test_public_ip_range.py
Intermitten failure detected: /marvin/tests/smoke/test_templates.py
Intermitten failure detected: /marvin/tests/smoke/test_usage.py
Intermitten failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermitten failure detected: /marvin/tests/smoke/test_volumes.py
Intermitten failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 60 look OK, 7 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
ContextSuite context=TestDeployVirtioSCSIVM>:setup	`Error`	0.00	test_deploy_virtio_scsi_vm.py
test_03_vpc_privategw_restart_vpc_cleanup	`Failure`	1100.34	test_privategw_acl.py
test_04_extract_template	`Failure`	128.30	test_templates.py
ContextSuite context=TestISOUsage>:setup	`Error`	0.00	test_usage.py
test_02_unsecure_vm_migration	`Error`	65.20	test_vm_life_cycle.py
test_06_download_detached_volume	`Failure`	136.52	test_volumes.py
test_hostha_enable_ha_when_host_in_maintenance	`Error`	4.48	test_hostha_kvm.py
test_hostha_kvm_host_degraded	`Error`	7.54	test_hostha_kvm.py

add allowed action resetSSHKeyForVirtualMachine when vm is in running…

48c121e

… state

rafaelweingartner approved these changes Jul 27, 2018

View reviewed changes

yadvr approved these changes Jul 31, 2018

View reviewed changes

yadvr merged commit a32bd46 into apache:4.11 Jul 31, 2018

yadvr added this to the 4.11.2.0 milestone Jul 31, 2018

ernjvr deleted the ssh_reset_visibility branch August 2, 2018 09:33

Conversation

ernjvr commented Jul 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

GitHub Issue/PRs

Screenshots (if appropriate):

How Has This Been Tested?

Checklist:

Uh oh!

rafaelweingartner commented Jul 27, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ernjvr commented Jul 27, 2018

Uh oh!

rafaelweingartner commented Jul 27, 2018

Uh oh!

borisstoyanov commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

borisstoyanov commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

borisstoyanov commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

borisstoyanov commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

borisstoyanov commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

blueorangutan commented Jul 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

ernjvr commented Jul 27, 2018 •

edited

Loading

rafaelweingartner commented Jul 27, 2018 •

edited

Loading