Skip to content

Bigger partiton table for SVM & ambigous redirect bugfix#2832

Merged
yadvr merged 3 commits into
apache:4.11from
DennisKonrad:4.11
Aug 31, 2018
Merged

Bigger partiton table for SVM & ambigous redirect bugfix#2832
yadvr merged 3 commits into
apache:4.11from
DennisKonrad:4.11

Conversation

@DennisKonrad
Copy link
Copy Markdown
Contributor

@DennisKonrad DennisKonrad commented Aug 30, 2018

Description

build.sh systemvmtemplate failed while pulling updates. Reason was ‘No Space Left on Device’ Error on the root partition.
So I went on and increased the partition size and it built succesfully.

Testing revealed, that the boot partition has to be bigger than 60MB to allow installing updates.

Also I had bash ambiguous redirect error in shar_cloud_scripts.sh wich I fixed by placing quotes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Built successfully via:
bash build.sh systemvmtemplate

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
    Testing
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@DennisKonrad DennisKonrad deleted the 4.11 branch August 30, 2018 13:24
@DaanHoogland
Copy link
Copy Markdown
Contributor

@DennisKonrad why did you close this one?

@DennisKonrad
Copy link
Copy Markdown
Contributor Author

DennisKonrad commented Aug 30, 2018

I am trying to squash another commit into this pull request because:
boot partion size at 60MB isnt working and 150MB as in my first pull request was too big for rohit.

Im tryning to wrap my head about git rebase and all the things to get this right.

I will reopen this if everything is looking like I want it to be.

@DennisKonrad DennisKonrad reopened this Aug 30, 2018
@DennisKonrad
Copy link
Copy Markdown
Contributor Author

Ok, I see how changes work now. I wasnt able to check if the 80MB for /boot are working right now.
For this I have to have my commits in my master also

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DennisKonrad don't bother with master. we will merge it forward once merged in 4.11

@DennisKonrad
Copy link
Copy Markdown
Contributor Author

DennisKonrad commented Aug 30, 2018

yeah, my current build infrastructure is using the master of my fork for automatically building the
systemvm.

So to not change my build infrastructure I wanted to pull the commit into my master to test if 80MB is working. I managed this now and the build is running at the moment.

I dont now if your CI infrastructure is checking at all if the SVM build is working so I would like to make sure this works before this change gets commited

@DennisKonrad
Copy link
Copy Markdown
Contributor Author

80 MB is working. LGTM now

@DaanHoogland DaanHoogland requested a review from yadvr August 30, 2018 15:08
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with the redirection fix, for the size related changes I'm building a systemvmtemplate with existing size of 1.8G to see if we can reproduce the build error.

@yadvr yadvr added this to the 4.11.2.0 milestone Aug 31, 2018
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Aug 31, 2018

I'll take +1/LGTM from @resmo from the previously closed PR #2827

@resmo
Copy link
Copy Markdown
Member

resmo commented Aug 31, 2018

LGTM

@yadvr yadvr merged commit 263559c into apache:4.11 Aug 31, 2018
bernardodemarco pushed a commit to scclouds/cloudstack that referenced this pull request Jul 16, 2025
Habilitação de suporte a SNI para as _system_ VMs

Closes apache#2832

See merge request scclouds/scclouds!1227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants