Skip to content

Volume snapshot recurring schedule not showing#2836

Merged
yadvr merged 1 commit into
apache:4.11from
ernjvr:recurring-snapshots
Sep 7, 2018
Merged

Volume snapshot recurring schedule not showing#2836
yadvr merged 1 commit into
apache:4.11from
ernjvr:recurring-snapshots

Conversation

@ernjvr
Copy link
Copy Markdown
Contributor

@ernjvr ernjvr commented Sep 5, 2018

Description

In the UI, when Setting up a recurring snapshot for a volume and clicking 'Add', the newly added scheduled snapshot entry is not displayed in the 'Scheduled Snapshots' table. Also, the 'Keep' input field does not limit the length of a number that can be added. This causes the API not return an error that the value is invalid.

After adding a recurring snapshot, it must display in the 'Scheduled Snapshots' table. The 'Keep' input field must restrain a user from entering too large of a number.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2831

Screenshots (if appropriate):

image
image
image

How Has This Been Tested?

Manually

In the UI, click on the 'Instance' button. Click on an instance. Click the 'View Volumes' button. Click on a specific volume. Click the 'Set up Recurring Snapshot' button. Add a Recurring Snapshot and observe that it now does display the newly added schedule. Also when adding a 'Keep' number, it will limit the user to a maximum of 9 numbers.

4.11
KVM

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@ernjvr
Copy link
Copy Markdown
Contributor Author

ernjvr commented Sep 5, 2018

@rafaelweingartner @rhtyd @nvazquez @borisstoyanov please review

Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Good finding with the closing tags

Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit a387272 into apache:4.11 Sep 7, 2018
@ernjvr ernjvr deleted the recurring-snapshots branch October 8, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants