Volume snapshot recurring schedule not showing#2836
Merged
Conversation
Contributor
Author
|
@rafaelweingartner @rhtyd @nvazquez @borisstoyanov please review |
nvazquez
approved these changes
Sep 6, 2018
Contributor
nvazquez
left a comment
There was a problem hiding this comment.
LGTM. Good finding with the closing tags
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the UI, when Setting up a recurring snapshot for a volume and clicking 'Add', the newly added scheduled snapshot entry is not displayed in the 'Scheduled Snapshots' table. Also, the 'Keep' input field does not limit the length of a number that can be added. This causes the API not return an error that the value is invalid.
After adding a recurring snapshot, it must display in the 'Scheduled Snapshots' table. The 'Keep' input field must restrain a user from entering too large of a number.
Types of changes
GitHub Issue/PRs
Fixes: #2831
Screenshots (if appropriate):
How Has This Been Tested?
Manually
In the UI, click on the 'Instance' button. Click on an instance. Click the 'View Volumes' button. Click on a specific volume. Click the 'Set up Recurring Snapshot' button. Add a Recurring Snapshot and observe that it now does display the newly added schedule. Also when adding a 'Keep' number, it will limit the user to a maximum of 9 numbers.
4.11
KVM
Checklist:
Testing