Skip to content

Fix PowerReportMissing for new VRs#2846

Merged
yadvr merged 1 commit into
apache:4.11from
resmo:fix/starting-vr-not-handled-cloudstack-CLOUDSTACK-8848
Sep 18, 2018
Merged

Fix PowerReportMissing for new VRs#2846
yadvr merged 1 commit into
apache:4.11from
resmo:fix/starting-vr-not-handled-cloudstack-CLOUDSTACK-8848

Conversation

@resmo
Copy link
Copy Markdown
Member

@resmo resmo commented Sep 17, 2018

Description

Fallback to update (and creating) time when power state update time is null.
Follow up of CLOUDSTACK-8848
(also see 542880a#diff-dd162c545fd70c5cf2c4b2fa599c13c9L114)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes #2845

Screenshots (if appropriate):

N/A

How Has This Been Tested?

Needs testing

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
    Testing
  • I have added tests to cover my changes.
  • All relevant new and existing integration tests have passed.
  • A full integration testsuite with all test that can run on my environment has passed.

@resmo resmo added the type:bug label Sep 17, 2018
@yadvr yadvr added this to the 4.11.2.0 milestone Sep 17, 2018
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 17, 2018

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2298

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Sep 17, 2018

@blueorangutan test centos7 vmware-65

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + vmware-65) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3012)
Environment: vmware-65 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31172 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2846-t3012-vmware-65.zip
Intermittent failure detected: /marvin/tests/smoke/test_deploy_vgpu_enabled_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_deploy_virtio_scsi_vm.py
Intermittent failure detected: /marvin/tests/smoke/test_outofbandmanagement.py
Intermittent failure detected: /marvin/tests/smoke/test_volumes.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestDeployVirtioSCSIVM>:teardown Error 0.00 test_deploy_virtio_scsi_vm.py

Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yadvr yadvr merged commit 223a373 into apache:4.11 Sep 18, 2018
@resmo resmo deleted the fix/starting-vr-not-handled-cloudstack-CLOUDSTACK-8848 branch September 18, 2018 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants