Fixes: #2881 Improve Exception message

[fmaximus]

Description

Network.Service and Network.Provider were missing a toString() method.
Added toString() methods so appending instances, or a collection of instances
to a String, will result in an understandable String.

Before

com.cloud.network.Network$Provider@11763e57 requires services: [com.cloud.network.Network$Service@4f9871a2]

After

Provider Network.Provider[name=NuageVsp] requires services: [Network.Service[name=Connectivity]]

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)

GitHub Issue/PRs

Fixes: #2881

How Has This Been Tested?

Manually, added Unit Test to validate exception message.

Checklist:

• I have read the CONTRIBUTING document.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
  Testing
• I have added tests to cover my changes.
• All relevant new and existing integration tests have passed.
• A full integration testsuite with all test that can run on my environment has passed.

[yadvr]

@blueorangutan package

[blueorangutan]

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

[yadvr]

@fmaximus while this looks to improve logging, I'm not sure if it will fix the root cause of #2881 /cc @borisstoyanov can you test?

[blueorangutan]

Packaging result: ✔centos6 ✔centos7 ✖debian. JID-2337

[yadvr]

@blueorangutan test

[blueorangutan]

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

[blueorangutan]

Trillian test result (tid-3071)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 24590 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr2889-t3071-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_privategw_acl.py
Intermittent failure detected: /marvin/tests/smoke/test_routers_network_ops.py
Smoke tests completed. 66 look OK, 1 have error(s)
Only failed tests results shown below:

Test	Result	Time (s)	Test File
test_03_vpc_privategw_restart_vpc_cleanup	Failure	1111.28	test_privategw_acl.py

[borisstoyanov]

yes @rhtyd, let me build env and verify this.

[borisstoyanov]

LGTM, now it has meaningful error message.