Skip to content

packaging: management default file cleanup#3139

Merged
yadvr merged 1 commit into
apache:4.11from
shapeblue:mgmt-default-file
Jan 25, 2019
Merged

packaging: management default file cleanup#3139
yadvr merged 1 commit into
apache:4.11from
shapeblue:mgmt-default-file

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Jan 19, 2019

This cleanups management server default file, the cloud.jks is no
longer created by the management server but instead created in-memory
by the root CA plugin on management server startup.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

This cleanups management server default file, the `cloud.jks` is no
longer created by the management server but instead created in-memory
by the root CA plugin on management server startup.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jan 19, 2019

Another issue investigation in progress: The -Djava.security.properties=/etc/cloudstack/management/java.security.ciphers does not override hte TLS algorithms settings with JDK8, however, overriding the global $JRE_HOME/lib/security/java.security disables TLS algorithms.

Copy link
Copy Markdown
Member

@GabrielBrascher GabrielBrascher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Copy Markdown
Contributor

@wido wido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GabrielBrascher
Copy link
Copy Markdown
Member

@rhtyd thanks for the PR!
Is it still a "work in progress"?

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jan 24, 2019

@GabrielBrascher removed the label. I'll investigate and may send another PR (perhaps a doc PR) on how to disable/configure TLS versions. Turns out the global way maybe the only appropriate way.
@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2562

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jan 24, 2019

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3343)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 36813 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3139-t3343-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_internal_lb.py
Intermittent failure detected: /marvin/tests/smoke/test_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_resource_accounting.py
Intermittent failure detected: /marvin/tests/smoke/test_vm_life_cycle.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Smoke tests completed. 65 look OK, 3 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces Error 3740.19 test_internal_lb.py
test_04_delete_domain_with_project Error 61.59 test_projects.py
ContextSuite context=TestRAMCPUResourceAccounting>:teardown Error 116.52 test_resource_accounting.py

@yadvr yadvr merged commit 463372b into apache:4.11 Jan 25, 2019
GabrielBrascher pushed a commit that referenced this pull request Feb 4, 2019
nvazquez pushed a commit to shapeblue/cloudstack that referenced this pull request Jul 24, 2019
This cleanups management server default file, the `cloud.jks` is no
longer created by the management server but instead created in-memory
by the root CA plugin on management server startup.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
(cherry picked from commit 463372b)
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants