Skip to content

api: Set network name as part of the network usage response#3234

Merged
yadvr merged 1 commit into
apache:masterfrom
shapeblue:network-usage-response-fix
Jun 20, 2019
Merged

api: Set network name as part of the network usage response#3234
yadvr merged 1 commit into
apache:masterfrom
shapeblue:network-usage-response-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Mar 25, 2019

Problem: Network name is not part of the network usage response
Root Cause: Code does not set the network name
Solution: Set the network name for network usage type usage records in the API response

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@borisstoyanov
Copy link
Copy Markdown
Contributor

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@borisstoyanov a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2652

@borisstoyanov
Copy link
Copy Markdown
Contributor

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@borisstoyanov a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

Trillian test result (tid-3451)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 33626 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr3234-t3451-kvm-centos7.zip
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups_projects.py
Intermittent failure detected: /marvin/tests/smoke/test_affinity_groups.py
Intermittent failure detected: /marvin/tests/smoke/test_vpc_redundant.py
Intermittent failure detected: /marvin/tests/smoke/test_hostha_kvm.py
Smoke tests completed. 66 look OK, 4 have error(s)
Only failed tests results shown below:

Test Result Time (s) Test File
test_DeployVmAntiAffinityGroup_in_project Error 65.51 test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup Error 37.59 test_affinity_groups.py
test_05_rvpc_multi_tiers Failure 413.78 test_vpc_redundant.py
test_05_rvpc_multi_tiers Error 441.94 test_vpc_redundant.py
test_hostha_enable_ha_when_host_in_maintenance Error 307.79 test_hostha_kvm.py
test_hostha_kvm_host_degraded Failure 698.07 test_hostha_kvm.py
test_hostha_kvm_host_fencing Failure 647.90 test_hostha_kvm.py
test_hostha_kvm_host_recovering Failure 646.92 test_hostha_kvm.py

@yadvr yadvr changed the title api: Set network name as part of the network usage response [WIP DO NOT MERGE] api: Set network name as part of the network usage response Mar 29, 2019
borisstoyanov
borisstoyanov approved these changes Apr 2, 2019
@yadvr yadvr requested a review from DagSonsteboSB May 10, 2019 18:15
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 23, 2019

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@rhtyd a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result: ✔centos6 ✔centos7 ✔debian. JID-2771

Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, network name is part of the response as well as the project and any tags if available:

list usagerecords type=5 startdate=2019-05-28 enddate=2019-05-29 includetags=true
    {
      "description": "network bytes received for Host: 6",
      "domain": "ROOT",
      "domainid": "aedcba99-8059-11e9-b304-1e00c301071f",
      "enddate": "2019-05-29'T'09:59:59+00:00",
      "name": "test-isolated",
      "networkid": "8c890707-2a84-452f-818c-c15c39c0bb94",
      "project": "test-project-fr6",
      "projectid": "7fe6e967-e045-48d0-80b3-ed6ed29751c2",
      "rawusage": "0",
      "startdate": "2019-05-29'T'09:00:00+00:00",
      "tags": [
        {
          "key": "isolated",
          "value": "with-project"
        }
      ],
      "type": "DomainRouter",
      "usage": "0 bytes received",
      "usageid": "8a4510fb-b2e8-487f-9b3b-348eab4ddc96",
      "usagetype": 5,
      "zoneid": "11aabe95-f621-4c04-977c-cbbf033c1797"
    }

@DaanHoogland
Copy link
Copy Markdown
Contributor

@rhtyd I think this is ready to merge (still tagged [WIP])

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jun 10, 2019

@DaanHoogland we're waiting for @PaulAngus or @andrijapanic 's test confirmation.

@andrijapanicsb
Copy link
Copy Markdown
Contributor

LGTM

@yadvr yadvr changed the title [WIP DO NOT MERGE] api: Set network name as part of the network usage response api: Set network name as part of the network usage response Jun 20, 2019
@yadvr yadvr merged commit 61ebc6a into apache:master Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants