ui: don't pass account name when in project mode to VMs from sshkeypair reference#3435
Conversation
|
ping for review - @rhtyd , @shwstppr , @svenvogel , @PaulAngus , @izenk |
There was a problem hiding this comment.
@anuragaw please go through the issue once again. While it may fix the issue of sshkeypair selection while deploying a VM (which I've not tested), the main issue is this:
In UI -> switch to project view -> click to "Accounts" -> choose "SSH keys" -> choose any ssh key -> click "View instances" Screen; you may see an exception.
Changes may be needed in accounts.js (search for listSSHKeyPairs usage).
|
@rhtyd - that's correct. When the above path is taken in UI the project name is passed into account name for view instances. We need to ignore the project account name since project id is already populated when we createURL |
|
Thanks @anuragaw so what you're saying is fix how to data is passed and rest is taken care of. Let's ask @svenvogel @DennisKonrad @pbankonier @NicoWohlfarth and other UI contributors for testing and review. |
|
That's correct @rhtyd . |
When users try to list instances in project mode from Account > SSHKeyPairs > Key > View Instances, we don't need to include sshkeypairs account name into the API Param. It's redundant and causes error.
Description
Fixes: #2895
Types of changes
Screenshots (if appropriate):
How Has This Been Tested?
Manually in UI try various combinations of reproducing bug in admin/user mode and switchng between regular and project view.