Skip to content

ui: don't pass account name when in project mode to VMs from sshkeypair reference#3435

Merged
yadvr merged 1 commit into
apache:masterfrom
anuragaw:ssh_ui_bug_2895
Jul 2, 2019
Merged

ui: don't pass account name when in project mode to VMs from sshkeypair reference#3435
yadvr merged 1 commit into
apache:masterfrom
anuragaw:ssh_ui_bug_2895

Conversation

@anuragaw
Copy link
Copy Markdown
Contributor

@anuragaw anuragaw commented Jun 28, 2019

When users try to list instances in project mode from Account > SSHKeyPairs > Key > View Instances, we don't need to include sshkeypairs account name into the API Param. It's redundant and causes error.

Description

Fixes: #2895

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Screenshots (if appropriate):

How Has This Been Tested?

Manually in UI try various combinations of reproducing bug in admin/user mode and switchng between regular and project view.

@anuragaw
Copy link
Copy Markdown
Contributor Author

ping for review - @rhtyd , @shwstppr , @svenvogel , @PaulAngus , @izenk

@yadvr yadvr added this to the 4.13.0.0 milestone Jun 28, 2019
@yadvr yadvr requested review from borisstoyanov and svenvogel June 28, 2019 06:24
@yadvr yadvr changed the title Don't pass account name when in project mode ui: don't pass account name when in project mode to list ssh publickeys Jun 28, 2019
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuragaw please go through the issue once again. While it may fix the issue of sshkeypair selection while deploying a VM (which I've not tested), the main issue is this:
In UI -> switch to project view -> click to "Accounts" -> choose "SSH keys" -> choose any ssh key -> click "View instances" Screen; you may see an exception.

Changes may be needed in accounts.js (search for listSSHKeyPairs usage).

@anuragaw
Copy link
Copy Markdown
Contributor Author

@rhtyd - that's correct. When the above path is taken in UI the project name is passed into account name for view instances. We need to ignore the project account name since project id is already populated when we createURL

@anuragaw anuragaw changed the title ui: don't pass account name when in project mode to list ssh publickeys ui: don't pass account name when in project mode to VMs from sshkeypair reference Jun 28, 2019
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 28, 2019

Thanks @anuragaw so what you're saying is fix how to data is passed and rest is taken care of. Let's ask @svenvogel @DennisKonrad @pbankonier @NicoWohlfarth and other UI contributors for testing and review.

@anuragaw
Copy link
Copy Markdown
Contributor Author

That's correct @rhtyd .

Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested locally.

@yadvr yadvr merged commit 14bf2e9 into apache:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ssh-keys instances ERROR

3 participants